Remove confusing random hint text, make conventional #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following convention I suggest "Example Site" as the issuer hint, and "[email protected]" as the label hint - consistent with the screenshots at https://freeotp.github.io/ . Existing random looking hint of "18c5d06cfcbd4927" for android:id="@+id/label" is confusing in a screen that already asks user to enter random strings in aid of math many do not understand. I love this app but to show how confusing this is it was easier for me, who knows computer languages, to find the file on Github and see "Oh, it's a label" from android:id="@+id/label" - than to work out purpose of field when seeing this random hint text for the 1st time. The IOS version (judging by https://github.com/freeotp/freeotp-ios/blob/master/FreeOTP/Base.lproj/Main.storyboard ) also seems to have better hint text for issuer and label. Hope to save other Android users any confusion. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following convention I suggest "Example Site" as the issuer hint, and "[email protected]" as the label hint - consistent with the screenshots at https://freeotp.github.io/ . If one does not scan a QR code to add a key: the existing random looking hint of "18c5d06cfcbd4927" for android:id="@+id/label" is confusing in a screen that already asks user to enter random strings in aid of math that many do not understand. I love this app but to show how confusing this is it was easier for me, who knows computer languages, to find the file on Github and see "Oh, it's a label" from android:id="@+id/label" - than to work out purpose of field when seeing this random hint text for the 1st time. The IOS version (judging by https://github.com/freeotp/freeotp-ios/blob/master/FreeOTP/Base.lproj/Main.storyboard ) also seems to have better hint text for issuer and label. Hope to save other Android users any confusion. Thank you.