-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formData fields support. #7
base: master
Are you sure you want to change the base?
Conversation
This will enable the Parser to parse field parts included in formData. Ej. (parsed data): parts: { name: 'name', data: 'test product' } { name: 'code', data: 'product code' } { name: 'category', data: 'product category' } { filename: 'productImage.jpg', type: 'image/jpeg', data: <Buffer ef bf bd ef bf bd ef bf bd ef bf bd 00 10 4a 46 49 46 00 01 01 00 00 01 00 01 00 00 ef bf bd ef bf bd 00 43 00 03 02 02 02 02 02 03 02 02 02 03 03 03 ... > }
This solves scenarios like
Tests for collections of multiple Image+data to follow... |
Still missing to test:
|
@rcfrias Tested this, now form data is working correctly. Thanks! |
i need to find some time for this project. 2 pending merge requests..very sorry, 3 jobs is hard. |
Thanks for this PR, works well for me too! Hope it gets merged soon |
I was getting an error for empty input fields - I was able to fix it by adding a try catch block around |
Thanks, this helped me a lot! |
Great!!! This PR worked for me. |
Why this pull request not merged? |
is there an ETA on the merging this PR |
It's been over 2 years, please merge this soon! This helps a lot! |
Faced the same issue and found that there's a forked repo where the issue is fixed - https://www.npmjs.com/package/parse-multipart-data. Just in case someone else needs it. |
MERGE THIS NOW. Please. It has solved my issues. |
im very sorry, i cant. because some critical components in my side is actively using the master branch as-is. so, because i cant perform testing to verify the impact in my products (and others, from different people) then: i cant. |
Ah okay. Gotcha. :)
…On Thu, Oct 7, 2021, 11:43 Christian ***@***.***> wrote:
im very sorry, i cant. because some critical components in my side is
actively using the master branch as-is. so, because i cant perform testing
to verify the impact in my products (and others, from different people)
then: i cant.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMGYHUYI3MYF3Y4WGZ6Z65TUFWW2JANCNFSM4DXKYEBA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
This will enable the Parser to parse field parts included in formData. Ej. (parsed data):
parts:
{ name: 'name', data: 'test product' }
{ name: 'code', data: 'product code' }
{ name: 'category', data: 'product category' }
{ filename: 'productImage.jpg',
type: 'image/jpeg',
data: <Buffer ef bf bd ef bf bd ef bf bd ef bf bd 00 10 4a 46 49 46 00 01 01 00 00 01 00 01 00 00 ef bf bd ef bf bd 00 43 00 03 02 02 02 02 02 03 02 02 02 03 03 03 ... > }