Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix voxel-size bug in surfa.image.framed.reorient() #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix voxel-size bug in surfa.image.framed.reorient() #43

wants to merge 1 commit into from

Conversation

yhuang43
Copy link
Contributor

Computing the voxsize from affine changed the values slightly. This also resulted in small differences in geom.

@yhuang43
fix voxel-size bug in surfa.image.framed.reorient()
fcd1f5b 
  Computing the voxsize from affine changed the values slightly. This also resulted in small differences in geom.
jnolan14
jnolan14 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@jnolan14 jnolan14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, should properly reorder the voxel sizes without introducing any change in the voxel sizes due to round off when calculating based on the new matrix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnolan14 jnolan14 jnolan14 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhuang43 @jnolan14