-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dhcp: add options for static leases, custom domain names and olsrd services #524
base: main
Are you sure you want to change the base?
Conversation
47a8f99
to
aad606a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me at a short wentthrough.
One notice on the OLRS-services:
Hence the service name field has a flexible string, there are a lot of letters, which are not allowed to be there. Otherwise they will stop the olsrd from start up.
For an exact list of them, refer to the service-registrar sanitize code please.
As bbb-configs is an expert toop, it should be enough, to mention that circumstance in the documentation.
I added validation for the olsrd services fields to avoid having an olsrd service that is not starting. |
0a888f5
to
b9cc657
Compare
I added documentation. I would love to get some more feedback on this / active testing. |
I know it's not in your code, but
config domain
Also, for my setup, I would prefer to limit the range of IPs on the dhcp network. For example, I have it set up so that the start is 50 and the limit is 200. I use the first 50 addresses for static leases and statically configured hosts (for prototyping and VM's). |
These changes should also be done in templates/gateway/config/ too. |
I still don't see any changes in templates/gateway/config/ |
Yes, not done yet... added all open tasks to the todo list of this PR (first post). |
Was ist hier der aktuelle Stand |
Der aktuelle Stand ist, dass es eigentlich erst sinnvoll ist dies fertig zu machen, wenn wir alle Geräte als Hosts beschreiben, also auch Antennen und Switches und die SNMP Profiles, DFS-Reset und eben auch services und leases dann auf die Hostbeschreibung wechseln. - So war zumindest mal der Plan den ich mit @FFHener besprochen hatte. |
Ich hab die Arbeit an dieser Migration dahin aktuell pausiert um die Sommermonate mich auf die Wartung zu fokussieren, würde aber nach meiner aktuellen Planung in das Thema wieder im Herbst einsteigen |
This allows to add static dhcp leases, custom domain names and olsrd services by adding a
dhcp.yml
/olsrd.yml
file to the location directory. This would resolve #265.The syntax of the dhcp.yml file is as follows:
The syntax of the olsrd.yml file is as follows:
This still misses documentation in the commit. Feedback is welcome.
Todo: