Feature/owm sh stargieg old api #185
Conversation
Signed-off-by: Patrick Grimm <[email protected]>
Signed-off-by: Patrick Grimm <[email protected]>
Signed-off-by: Patrick Grimm <[email protected]>
Signed-off-by: Martin Hübner <[email protected]>
akira25
force-pushed
the
feature/owm_sh_stargieg_old_api
branch
from
c9977ea to
56c2f15
Compare
akira25
force-pushed
the
feature/owm_sh_stargieg_old_api
branch
2 times, most recently
from
bbf13bd to
8225488
Compare
akira25
force-pushed
the
feature/owm_sh_stargieg_old_api
branch
from
8225488 to
d116a5b
Compare
| json_add_string sourceAddr4 "$1" | ||
| json_add_string destAddr4 "$2" | ||
| json_add_string id "$3" | ||
| #json_add_string quality "$4" |
There was a problem hiding this comment.
I'ts a relict from the development process. I removed it.
| if [ -n "$phone" ]; then json_add_string phone "$phone"; fi | ||
| if [ -n "$homepage" ]; then json_add_string homepage "$homepage"; fi #ToDo: list of homepages | ||
| if [ -n "$note" ]; then json_add_string note "$note"; fi | ||
| # ToDo: add location-string |
There was a problem hiding this comment.
You did not add the location string?
There was a problem hiding this comment.
In fact the location string was never sent to owm. So I removed it too. Was just like a deprecated reminder to myself.
akira25
force-pushed
the
feature/owm_sh_stargieg_old_api
branch
from
d116a5b to
5bbb299
Compare
|
Thanks for putting all your effort into this project! :) But couldn't we rename this project to something else? It hast nothing to do with luci? |
Was the question on luci really a question or an statement? It has to do with luci. The package provides a luci-app for something. Even if we decide to remove that luci-stuff, that should definitely go into another PR, as this definitely wouldn't relate to #159. Please don't start nitpicking. :-) |
|
@PolynomialDivision |
|
This needs a migration script for those who upgrade the firmware. The migration script needs to change the cronjob. I did not take a complete look at the script. More to come later.... |
As OpenWrt will stop its use of lua in the next time, we decided to reimplement the owm.lua script, which pushes node data to the openwifimap api. This script implements some kind of owm-api v1.0. It's a basis for the new owm-api-script, which we can write, after we found a definition for the new format. Signed-off-by: Martin Hübner <[email protected]>
akira25
force-pushed
the
feature/owm_sh_stargieg_old_api
branch
from
5bbb299 to
c7bd274
Compare
|
Am I allowed to package that and put that into openwrt/packages ? I would also add procd support. I really don't understand the reason for doing this as luci-app? We currently do not use any luci component from it? |
There is some antenna stuff in this app too. As I currently don't fully understand the impact of that antenna-stuff, I'd really like postpone that issue into a later PR. In concern of OpenWrt: Why should this get part of OpenWrt? It's obviously Freifunk Berlin specific software. In addition this script will change in near feature. I don't want to discuss with the OpenWrt-Devs, that propably don't know our needs. |
It is a owm project. This can be used for arbitrary projects. In addition, I would re-name config files to owm or openwifimap. I would say if we hold it generic, all people ca benefit from it. Maybe other people also want to do similar things. |
|
I think it would be better to get the Falter specific version merged first and then to think about how to generalize later. |
|
I agree. Could someone hit that merge button then please? |
|
Should this be cherry-picked into 2102? 1907? |
It should be cherry-picked to 21.02 only. |
Description:
This should fix #159 for a short while. further improvements on this can be taken, when the discussion in freifunk/openwifimap-api#13 is finished.