Remove libm dependency #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prefix_len must be in a range between 8 and 32 to be useable. Check the upper bound as well. Co-authored-by: BenBE <[email protected]> Signed-off-by: Tobias Stoeckmann <[email protected]>
The number of blocks can be calculated without libm functionality. Since power of two arguments are passed as command line arguments we can simply continue calculating with these exponents. Co-authored-by: BenBE <[email protected]> Signed-off-by: Tobias Stoeckmann <[email protected]>
neocturne
reviewed
May 29, 2023
| config.block_size = 32; | ||
| unsigned int block_size_pow = 5; | ||
|
|
||
| config.block_size = 1 << block_size_pow; |
There was a problem hiding this comment.
Do we need to initialize block_size here at all? Is it used anywhere before l.423?
There was a problem hiding this comment.
A quick scan through the source showed no places where this field seems to be read in the affected part of the code. Not tested, but it should be safe to drop that assignment in line 215.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculating with floating point precision can be avoided by using power of two and exponents given through command line arguments.
This removes the libm requirement from the resulting binary.