Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "next" autoupdater branch #534

Merged

Conversation

grische
Copy link
Contributor

@grische grische commented Jan 1, 2025

This should not be required anymore thanks to freifunkMUC/ffmuc-salt-public#165

@grische grische force-pushed the remove-next-autoupdater-branch branch from d7e7276 to d5280dc Compare January 1, 2025 15:33
@T0biii
Copy link
Member

T0biii commented Jan 1, 2025

Sounds good the branch gluon-next would be our new next or?

@grische
Copy link
Contributor Author

grische commented Jan 1, 2025

@T0biii I don't see a reason why we would need anymore next with the changes. There should only be a stable, experimental and testing branch.

@T0biii
Copy link
Member

T0biii commented Jan 1, 2025

than we need to remove next from the site.conf?

@grische
Copy link
Contributor Author

grische commented Jan 1, 2025

I'm not sure of the side effects for this. I would probably do it in a later release.

EDIT: I will investigate if it is safe to remove it here

@grische grische marked this pull request as draft January 2, 2025 12:18
@grische
Copy link
Contributor Author

grische commented Jan 2, 2025

From what I understand, a removed branch is not removed from uci and hence nothing happens to devices that have the branch configured: https://github.com/freifunk-gluon/gluon/blob/v2023.2.x/package/gluon-autoupdater/luasrc/lib/gluon/upgrade/500-autoupdater#L10-L12

Tested it on a Cudy and it seems to work just fine:
https://gist.github.com/grische/6fde9e4cc79fdcd2ea16449f38fbf2d4

I think we are good to go, once the CI is happy.

@grische grische marked this pull request as ready for review January 2, 2025 13:35
@grische grische merged commit 8e4e3d3 into freifunkMUC:gluon-v2023.2.x Jan 2, 2025
32 checks passed
@grische grische deleted the remove-next-autoupdater-branch branch January 2, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants