-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove "next" autoupdater branch #534
remove "next" autoupdater branch #534
Conversation
With freifunkMUC/ffmuc-salt-public#181 merged there is no need anymore for a "next" channel.
d7e7276
to
d5280dc
Compare
Sounds good the branch |
@T0biii I don't see a reason why we would need anymore next with the changes. There should only be a stable, experimental and testing branch. |
than we need to remove next from the site.conf? |
I'm not sure of the side effects for this. I would probably do it in a later release. EDIT: I will investigate if it is safe to remove it here |
From what I understand, a removed branch is not removed from uci and hence nothing happens to devices that have the branch configured: https://github.com/freifunk-gluon/gluon/blob/v2023.2.x/package/gluon-autoupdater/luasrc/lib/gluon/upgrade/500-autoupdater#L10-L12 Tested it on a Cudy and it seems to work just fine: I think we are good to go, once the CI is happy. |
This should not be required anymore thanks to freifunkMUC/ffmuc-salt-public#165