fix random color on minimal values #2273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmatthias
reviewed
Jan 27, 2025
| @@ -1,3 +1,3 @@ | |||
| export default function () { | |||
| return `#${((Math.random() * 0xffffff) << 0).toString(16)}`; | |||
| return `#${(Math.floor(Math.random() * (0xFFFFFF - 0x100000 + 1)) + 0x100000).toString(16)}`; | |||
There was a problem hiding this comment.
What's the exact bug you're trying to fix?
are you sure this still allows for the full range of colors?
unless i'm mistaking (and based on my testing) - this won't allow for any 0x0..... codes anymore.
if it's for "too short" values (which seem to be possible with very low values - and is my assumption for what this aims to fix) - maybe
Math.floor(Math.random() * 0xffffff).toString(16).padStart(6, '0') is a better solution?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for color generation function to not create colors from 5 characters for indicators