Header and Footer Cleanups #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwade
commented
Nov 13, 2024
| .content { | ||
| padding: 0 2px; | ||
| } | ||
| min-height: 100vh; |
There was a problem hiding this comment.
Make sure the footer is off-screen at start, even for short pages
wilwade
commented
Nov 13, 2024
| @@ -155,15 +155,7 @@ h6:target::before { | |||
|
|
|||
| .content { | |||
| overflow-y: auto; | |||
| padding: 30px 15px; | |||
There was a problem hiding this comment.
Moved this to tailwind classes to easily handle responsive breaks
wilwade
commented
Nov 13, 2024
| @@ -69,22 +69,6 @@ | |||
| @apply opacity-100; | |||
| transform: translate3d(0, 0, 0); | |||
| } | |||
|
|
|||
| /* Form common styles*/ | |||
There was a problem hiding this comment.
No form styles needed
wilwade
commented
Nov 13, 2024
| @@ -97,6 +81,11 @@ | |||
| margin: 0.67em 0; | |||
| } | |||
|
|
|||
| /* Reset the margins for the first header in the contents */ | |||
| .content h1:first-of-type { | |||
There was a problem hiding this comment.
Moved to be closer to the thing it is modifying
wilwade
commented
Nov 13, 2024
| @@ -15,6 +15,17 @@ | |||
| url("../fonts/Newake-Font-Regular.svg#filename") format("svg"); | |||
| } | |||
|
|
|||
| @font-face { | |||
There was a problem hiding this comment.
Added Bold and rearranged as needed for @font-face
wilwade
commented
Nov 13, 2024
| @@ -202,21 +202,21 @@ | |||
| }); | |||
| </script> | |||
|
|
|||
| <div id="content" class="content"> | |||
| <div id="content" class="content pt-8 pb-32 pl-[6px] pr-[45px]"> | |||
There was a problem hiding this comment.
Handles the left nav buttons better
wilwade
commented
Nov 13, 2024
| <!-- Mobile navigation buttons --> | ||
| {{#previous}} | ||
| <a rel="prev" href="{{ path_to_root }}{{link}}" class="mobile-nav-chapters previous" title="Previous chapter" aria-label="Previous chapter: {{title}}" aria-keyshortcuts="Left"> | ||
| <a rel="prev" href="{{ path_to_root }}{{link}}" class="mobile-nav-chapters previous mb-6 w-full md:w-auto" title="Previous chapter" aria-label="Previous chapter: {{title}}" aria-keyshortcuts="Left"> |
There was a problem hiding this comment.
Go full width on mobile and margins for stacking
wilwade
commented
Nov 13, 2024
| @@ -227,7 +227,7 @@ | |||
| </div> | |||
|
|
|||
| <!-- Custom Footer Start --> | |||
| <footer id="footer" class="bg-white px-6 md:px-[10%] max-w-[100vw]"> | |||
| <footer id="footer" class="bg-white pt-6 px-6 md:px-[10%] max-w-[100vw]"> | |||
There was a problem hiding this comment.
Slight top padding to separate the nav bar from the footer border
wilwade
force-pushed
the
dp/header-footer-fixes
branch
from
d5f891f to
6f2184e
Compare
saraswatpuneet
approved these changes
Nov 13, 2024
This was referenced Nov 13, 2024
wilwade
added a commit
that referenced
this pull request
Nov 19, 2024
Problem ======= Various small layout issues addressed (one of a few PRs for this sort of stuff) Closes #101 Closes #104 Closes #86 Part of #87 Solution ======== - Fix font issue with Bold - Remove dead styles - Fix content margins to handle the left nav buttons with centering - Fix the previous/next buttons on mobile - Add a margin to the footer to fix the footer border from hitting the side nav (slight design break)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Various small layout issues addressed (one of a few PRs for this sort of stuff)
Closes #101
Closes #104
Closes #86
Part of #87
Solution
Screenshots (optional):