Pile of Minor Fixes #110
Merged
Pile of Minor Fixes #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwade
commented
Nov 15, 2024
| @@ -0,0 +1,74 @@ | |||
| .button-links, | |||
There was a problem hiding this comment.
Separated out for easier handling
wilwade
commented
Nov 15, 2024
Comment on lines
+71
to
+73
| border: 2px solid var(--button-nav-hover-border); | ||
| color: var(--button-nav-hover-fg); | ||
| background: var(--button-nav-hover-bg); |
There was a problem hiding this comment.
Cleaned up these variables
wilwade
commented
Nov 15, 2024
| @@ -46,25 +46,25 @@ | |||
| } | |||
|
|
|||
| /* Individual icons for specific items (1 indexed) */ | |||
| #toc > .chapter li.chapter-item:nth-child(2) > a:first-of-type::before { | |||
| #toc > .chapter > li.chapter-item:nth-child(2) > a:first-of-type::before { | |||
There was a problem hiding this comment.
These were only supposed to catch the icon ones.
wilwade
commented
Nov 15, 2024
| padding-inline-start: 0; | ||
| display: flex; | ||
| align-items: center; | ||
| flex: 1; | ||
| } | ||
|
|
||
| #toc > .chapter > li > .section > li.chapter-item:first-of-type { | ||
| margin-top: 10px; |
There was a problem hiding this comment.
Fix the margin under the first one under the icons (Aka just Core > Arch for now)
aramikm
approved these changes
Nov 15, 2024
wilwade
commented
Nov 15, 2024
| @@ -376,6 +385,7 @@ mark { | |||
| margin-block-end: -1px; | |||
| margin-inline-start: -3px; | |||
| margin-inline-end: -3px; | |||
| color: var(--fg); | |||
There was a problem hiding this comment.
Search text color fix
wilwade
commented
Nov 15, 2024
| @@ -11,28 +11,57 @@ | |||
| --mono-font: "Source Code Pro", Consolas, "Ubuntu Mono", Menlo, "DejaVu Sans Mono", monospace, monospace; | |||
| --code-font-size: 0.875em /* please adjust the ace font size accordingly in editor.js */; | |||
| --header-height: 85px; | |||
|
|
|||
| /* Colors from Style Guide */ | |||
There was a problem hiding this comment.
Pulled these in and used them to keep things straight(er)
wilwade
added a commit
that referenced
this pull request
Nov 19, 2024
Problem ======= Various small fixes for the final tweaks of the docs Closes: #87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Various small fixes for the final tweaks of the docs
Closes: #87
Solution
#to be visible with the new header font