update with new colors #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix DelegationModel.svg
shannonwells
commented
Oct 29, 2024
| @@ -138,8 +142,6 @@ a > .hljs { | |||
| .menu-bar:visited, | |||
| .nav-chapters, | |||
| .nav-chapters:visited, | |||
| .mobile-nav-chapters, | |||
There was a problem hiding this comment.
These two being here was making it impossible to see button links and some links within text. The style was/is applied regardless of whether it's actually mobile size. I didn't correct that part, just made it visible.
shannonwells
commented
Oct 29, 2024
pages/images/ParachainModel-Dark.svg
Outdated
There was a problem hiding this comment.
There was a lot of the "cream" color from a previous update. This was converted to white.
shannonwells
commented
Oct 29, 2024
pages/images/ParachainModel.svg
Outdated
There was a problem hiding this comment.
Same here but it's more obvious from the picture.
shannonwells
requested review from
wilwade,
enddynayn,
aramikm and
claireclark1
wilwade
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
These changes look good an no reason to block them. A few questions however:
- The Frequency Logo is hidden, but I assume that is due to the static header that will change that.
- Do we still want the left/right nav buttons? If so, I think we might want to to switch to the style guide's primary (teal) buttons, but the hover on those doesn't work on white currently. @claireolmstead might have some thoughts?
- The Style Light/Dark dropdown in Light mode is all dark currently, although we don't know if that is staying around either.
- We likely need a new color for the active mode on the sidebar in light mode. @claireolmstead ideas?
wilwade
pushed a commit
that referenced
this pull request
Nov 19, 2024
Problem ======= Theme adjustments for MD book to reflect current mocks Closes #81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Theme adjustments for MD book to reflect current mocks
Closes #81
Steps to Verify:
git fetch && git checkout feat/update-colors npm install npm run serveScreenshots (optional):