execute runner jobs in container #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
demisx
force-pushed
the
1136-run-ci-jobs-in-container
branch
26 times, most recently
from
8ba48c5 to
29f5480
Compare
demisx
force-pushed
the
1136-run-ci-jobs-in-container
branch
3 times, most recently
from
78e53e1 to
8781cae
Compare
demisx
commented
Mar 2, 2023
| cargo llvm-cov -v --no-fail-fast --workspace --lcov --output-path lcov.info \ | ||
| --ignore-filename-regex "^.*\/(mock\.rs|weights(\.rs)?|benchmarking\.rs).*$" \ | ||
| --exclude "frequency,frequency-cli,frequency-runtime,frequency-service" \ | ||
| --features all-frequency-features |
There was a problem hiding this comment.
Making sure the same crate is used to generate coverage in this workflow as in "Verify PR" one.
demisx
commented
Mar 2, 2023
| run-integration-tests: | ||
| - '**/*.rs' | ||
| - '**/Cargo.toml' | ||
| - 'integration-tests/**/*.{ts,json}' | ||
| - '.github/**/*.yml' |
There was a problem hiding this comment.
I want changes in .github/ folder trigger all jobs as a sanity check. I found myself constantly adding a temporary delete file just to do the same.
demisx
commented
Mar 2, 2023
|
|
||
| # Workaround to handle skipped required check inside matrix | ||
| # https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks | ||
| build-binaries-dummy: | ||
| needs: changes | ||
| if: needs.changes.outputs.build-binary != 'true' | ||
| runs-on: ubuntu-20.04 | ||
| container: ubuntu:20.04 |
There was a problem hiding this comment.
Using official Ubuntu 20.04 image for now. I will probably create CI dedicated image in a subsequent PR with preinstalled tools and libs.
demisx
force-pushed
the
1136-run-ci-jobs-in-container
branch
from
8781cae to
d510e3f
Compare
demisx
force-pushed
the
1136-run-ci-jobs-in-container
branch
from
d510e3f to
0ee68f6
Compare
demisx
commented
Mar 3, 2023
| - name: Check Out Repo | ||
| uses: actions/checkout@v3 | ||
| - name: Reset Runner | ||
| uses: ./.github/workflows/common/reset-self-hosted-runner |
There was a problem hiding this comment.
No need for manually resetting anymore.
demisx
force-pushed
the
1136-run-ci-jobs-in-container
branch
13 times, most recently
from
a8eaf1a to
c4faf7c
Compare
saraswatpuneet
approved these changes
Mar 6, 2023
wilwade
approved these changes
Mar 6, 2023
demisx
force-pushed
the
1136-run-ci-jobs-in-container
branch
from
c4faf7c to
fe26f9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to move jobs to docker executor in the following workflows:
Part of #1136