Fix/e2e test improvements #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwade
commented
Oct 23, 2024
| @@ -0,0 +1,226 @@ | |||
| import '@frequency-chain/api-augment'; | |||
There was a problem hiding this comment.
Moved from transactions.test.ts. No changes
wilwade
commented
Oct 23, 2024
| @@ -1,10 +1,8 @@ | |||
| import '@frequency-chain/api-augment'; | |||
There was a problem hiding this comment.
Only moved some tests to capacityFail.test.ts. No other changes.
wilwade
commented
Oct 23, 2024
| @@ -11,7 +11,7 @@ import { hasRelayChain } from '../scaffolding/env'; | |||
| import { getFundingSource } from '../scaffolding/funding'; | |||
|
|
|||
| const fundingSource = getFundingSource('handles'); | |||
| const expirationOffset = hasRelayChain() ? 10 : 100; | |||
| const expirationOffset = hasRelayChain() ? 4 : 100; | |||
There was a problem hiding this comment.
With testnet at 6s block times, this can be reduced
wilwade
commented
Oct 23, 2024
e2e/passkey/passkeyProxy.test.ts
Outdated
| @@ -68,7 +68,7 @@ describe('Passkey Pallet Tests', function () { | |||
| const passkeyPayload = await createPasskeyPayload(passKeyPrivateKey, passKeyPublicKey, passkeyCall, false); | |||
| const passkeyProxy = ExtrinsicHelper.executePassKeyProxy(fundedKeys, passkeyPayload); | |||
| assert.doesNotReject(passkeyProxy.fundAndSendUnsigned(fundingSource)); | |||
| await ExtrinsicHelper.runToBlock(await getNextEpochBlock()); | |||
| await ExtrinsicHelper.waitForFinalization(); | |||
There was a problem hiding this comment.
Bugfix. This should have been this all along.
wilwade
commented
Oct 23, 2024
| while (currentBlock < blockNumber) { | ||
| if (start + 48_000 < Date.now()) { | ||
| throw new Error( | ||
| `Waiting for Finalized Block took longer than 48s. Waiting for "${blockNumber.toString()}", Current: "${currentBlock.toString()}"` |
There was a problem hiding this comment.
This is a life saver. Some of these were taking forever and it was really hard to track down. Now they are capped.
wilwade
requested review from
a team,
shannonwells,
mattheworris,
enddynayn,
aramikm,
claireolmstead and
JoeCap08055
and removed request for
a team
JoeCap08055
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to add a final set of e2e test improvements to allow e2e tests to run against testnet again post async-backing
Closes #2154
Discussion
Testing