fix: make e2e tests for passkey more rigorous in their success checks #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeCap08055
requested review from
wilwade,
pfrank13,
aramikm and
saraswatpuneet
JoeCap08055
commented
Dec 30, 2024
Comment on lines
-49
to
-52
| await assert.doesNotReject(passkeyProxy.fundAndSendUnsigned(fundingSource)); | ||
| await ExtrinsicHelper.waitForFinalization((await getBlockNumber()) + 2); | ||
| // adding some delay before fetching the nonce to ensure it is updated | ||
| await new Promise((resolve) => setTimeout(resolve, 1000)); |
There was a problem hiding this comment.
We don't need to await finalization now that sendUnsigned has been fixed to not resolve until the extrinsic is included in a finalized block.
JoeCap08055
commented
Dec 30, 2024
| @@ -264,6 +264,10 @@ export class Extrinsic<N = unknown, T extends ISubmittableResult = ISubmittableR | |||
| public async fundAndSendUnsigned(source: KeyringPair) { | |||
| await this.fundOperation(source); | |||
| log('Fund and Send', `Fund Source: ${getUnifiedAddress(source)}`); | |||
| return this.sendUnsigned(); | |||
There was a problem hiding this comment.
Deleted code block; now that sendUnsigned is doing what this block used to do.
enddynayn
reviewed
Dec 30, 2024
| const accountPKey = getUnifiedPublicKey(fundedSr25519Keys); | ||
| const nonce = await getNonce(fundedSr25519Keys); | ||
| const transferAmount = 55_000_000n; |
There was a problem hiding this comment.
Do we have constants for these like DOLLARS and CENTS?
There was a problem hiding this comment.
Not sure, but the amount isn't important anyway; we just want to be sure to check that whatever amount is transferred, the balance changes by that amount.
There was a problem hiding this comment.
But that does remind me, it would be good to also check that the correct sender's balance decreases by the appropriate amount.
pfrank13
approved these changes
Dec 30, 2024
…c errors on failures
JoeCap08055
added a commit
that referenced
this pull request
Jan 2, 2025
…#2246) # Goal The goal of this PR is to make the e2e tests for the passkey pallet a bit more discerning, and more clear to read. Previously, the tests were determining a successful token transfer by the absence of an exception and an increased nonce. While this is technically correct, according to the logic by which the extrinsic call would complete with no exceptions, it is a bit opaque. This PR enhances the test conditions to check that: * The appropriate events are generated in the block, and the event contents are correct * The correct reciever's balance is incremented by the transfer amount * The correct sender's balance is decremented by the transfer amount + fee * Failure tests are enhance to check the specific error that caused the failure Test conditions for the success cases are also enhanced so that successful tests are more verbose, as each check is encapsulated in a separate test block. Also, the function `Extrinsic.sendUnsigned()` was fixed to properly parse and return the event stream from the blockchain, in the same manner that `Extrinsic.signAndSend()` does. # Checklist - [ ] Updated Pallet Readme? - [ ] Updated js/api-augment for Custom RPC APIs? - [ ] Design doc(s) updated? - [ ] Unit Tests added? - [ ] e2e Tests added? - [ ] Benchmarks added? - [ ] Spec version incremented?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to make the e2e tests for the passkey pallet a bit more discerning, and more clear to read.
Previously, the tests were determining a successful token transfer by the absence of an exception and an increased nonce. While this is technically correct, according to the logic by which the extrinsic call would complete with no exceptions, it is a bit opaque.
This PR enhances the test conditions to check that:
Test conditions for the success cases are also enhanced so that successful tests are more verbose, as each check is encapsulated in a separate test block.
Also, the function
Extrinsic.sendUnsigned()was fixed to properly parse and return the event stream from the blockchain, in the same manner thatExtrinsic.signAndSend()does.Checklist