Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests from the SDK v1.0.0-rc5 #12

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Add more tests from the SDK v1.0.0-rc5 #12

merged 4 commits into from
Feb 29, 2024

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Feb 28, 2024

  • Add more tests imported from the SDK v1.0.0-rc5
  • Fix new tests imports
  • Fix new tests patching

@llucax llucax requested review from a team as code owners February 28, 2024 14:19
@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:client Affects the client code labels Feb 28, 2024
@llucax
Copy link
Contributor Author

llucax commented Feb 28, 2024

Based on #11, only the last 3 commits are relevant to this PR.

@llucax llucax self-assigned this Feb 28, 2024
@llucax llucax added this to the v0.1.0 milestone Feb 28, 2024
@llucax llucax added cmd:skip-release-notes It is not necessary to update release notes for this PR and removed part:client Affects the client code part:docs Affects the documentation labels Feb 28, 2024
tiyash-basu-frequenz
tiyash-basu-frequenz reviewed Feb 29, 2024
View reviewed changes
tests/test_component.py Show resolved Hide resolved
tests/test_component.py Outdated Show resolved Hide resolved
tests/test_connection.py Show resolved Hide resolved
tests/test_mock_api.py Show resolved Hide resolved
tests/test_timeout.py Outdated Show resolved Hide resolved
@llucax llucax mentioned this pull request Feb 29, 2024
Open
@github-actions github-actions bot added part:docs Affects the documentation part:client Affects the client code labels Feb 29, 2024
@llucax
Add more tests imported from the SDK v1.0.0-rc5
847d7df 
These tests were overlooked when doing the initial import, so we import
them now. They are a verbatim copy of the SDK, they will be fixed to
work in this repository in follow-up commits.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Fix new tests imports
794d586 
Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Fix new tests patching
b767b66 
Besides fixing the *path* to the symbol to patch, we now use an autouse
fixture to patch the tests automatically.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Fix/improve test_timeout.py docstrings
0f1962e 
Signed-off-by: Leandro Lucarella <[email protected]>
@llucax llucax enabled auto-merge February 29, 2024 10:32
@llucax llucax added this pull request to the merge queue Feb 29, 2024
@llucax llucax closed this Feb 29, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit 77c2f93 Feb 29, 2024
14 checks passed
@llucax llucax deleted the more-tests branch February 29, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiyash-basu-frequenz tiyash-basu-frequenz tiyash-basu-frequenz approved these changes

@shsms shsms Awaiting requested review from shsms shsms is a code owner automatically assigned from frequenz-floss/python-sdk-team

Assignees

@llucax llucax

Labels
cmd:skip-release-notes It is not necessary to update release notes for this PR part:client Affects the client code part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@llucax @shsms @tiyash-basu-frequenz