Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reactive power retrieval #927

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Apr 12, 2024

The data sourcing actor needs to know about the new metric. This commit exposes it, adds a trivial test and updates the release notes to do a hotfix right after this is merged.

llucax added 2 commits April 12, 2024 14:17
Signed-off-by: Leandro Lucarella <[email protected]>
The data sourcing actor needs to know about the new metric. This commit
exposes it, adds a trivial test and updates the release notes to do a
hotfix right after this is merged.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax llucax requested a review from a team as a code owner April 12, 2024 17:19
@llucax llucax requested a review from shsms April 12, 2024 17:19
@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:actor Affects an actor ot the actors utilities (decorator, etc.) labels Apr 12, 2024
@llucax llucax added this to the v1.0.0-rc6.1 milestone Apr 12, 2024
@llucax llucax self-assigned this Apr 12, 2024
@llucax
Copy link
Contributor Author

llucax commented Apr 12, 2024

Maybe give it a test too @matthias-wende-frequenz ? It seems to work for me locally, but just in case.

@llucax llucax enabled auto-merge April 12, 2024 17:20
@llucax
Copy link
Contributor Author

llucax commented Apr 12, 2024

(based on #926, but I guess both can be merged via this PR too)

@llucax llucax added this pull request to the merge queue Apr 12, 2024
Merged via the queue into frequenz-floss:v1.x.x with commit cf75848 Apr 12, 2024
13 of 14 checks passed
@llucax llucax deleted the fix-reactive-power branch April 12, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:actor Affects an actor ot the actors utilities (decorator, etc.) part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests
Projects
Development

Successfully merging this pull request may close these issues.

2 participants