Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create function to edit field properties #153

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

nepito
Copy link
Contributor

@nepito nepito commented Sep 20, 2023

Implement the functions suggested in the #70 :

  • add_description()
  • edit_fields()

add_description()

iris_schema <- create_schema(iris) |>
  add_description(
    c(
      "Sepal length in cm.",
      "Sepal width in cm.",
      "Pedal length in cm.",
      "Pedal width in cm.",
      "Iris species."
    )
  )

edit_fields()

iris_schema <- edit_fields(
    iris_schema,
    "description",
    values
  )

@nepito
Copy link
Contributor Author

nepito commented Sep 20, 2023

add_description()

Here is an example.

edit_fields()

Here is the other example.

@peterdesmet
Copy link
Member

Hi @nepito, thanks for the PR! It might take a while before I can review it, but I do hope to get a new version 1.1.0 out before the end of the year (which this could be part of).

Quick question already: it is possible to implement this without the added dependency comprehenr?

@peterdesmet peterdesmet added this to the 1.1.0 milestone Sep 20, 2023
@nepito
Copy link
Contributor Author

nepito commented Sep 21, 2023

Hi @nepito, thanks for the PR! It might take a while before I can review it, but I do hope to get a new version 1.1.0 out before the end of the year (which this could be part of).

Quick question already: it is possible to implement this without the added dependency comprehenr?

Hi @peterdesmet , I removed the dependency comprehenr.

@peterdesmet peterdesmet added the enhancement New feature or request label Nov 13, 2023
@peterdesmet
Copy link
Member

@nepito I have revisited #70, and provided my suggestion on how to move forward. Your feedback is welcome. The building blocks for it are included in the PR you created, but we'll only be able to implement it after we have released upcoming version 1.1.0.

@peterdesmet peterdesmet removed this from the 1.1.0 milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants