Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread time #705

Closed
wants to merge 1 commit into from
Closed

Thread time #705

wants to merge 1 commit into from

Conversation

WorksButNotTested
Copy link
Contributor

@WorksButNotTested WorksButNotTested commented Dec 23, 2022

Please note that this PR also contains the following:

This is because the RunOnThread functionality is necessary for it to function.
This PR adds support for reading user_time (the time the CPU has spent executing in user-mode in microseconds) on Linux and Android based systems. Similar support for other systems should be relatively straightforward, but aren't included in this PR.

@oleavr
Copy link
Member

oleavr commented May 10, 2024

How about improving libs/prof to add a Sampler implementation for this? We could then expose that to JS, and get the benefit of the other samplers too.

@WorksButNotTested
Copy link
Contributor Author

That sounds good. I can add the sampler pretty easily, but wasn't sure where to start with the JS bindings without ending up with a load of duplication?

@oleavr
Copy link
Member

oleavr commented May 12, 2024

That sounds good. I can add the sampler pretty easily, but wasn't sure where to start with the JS bindings without ending up with a load of duplication?

Awesome! I started on JS bindings here, though there's not much there it might provide some useful context. Can't believe it's been 7 years since then! 🫠

@WorksButNotTested
Copy link
Contributor Author

Superseded by #800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants