-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposed memory_read , memory_write and memory_scan gum functions #795
Conversation
These need to go inside the @oleavr anything else you’d like to see added from |
Hey, i updated the code and for the tests yeah of course, where to add them ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you rebase this on latest main? Just from a quick look it seems the added code references types that aren't present, so I suspect this will break the CModule runtime.
I tend to add things as I find myself needing them, but yeah those sound good to me. |
You can find them in |
(Sorry it took me so long to review -- I was stuck in a rabbit-hole, and have now finally made it out.) |
Note that tests should be super-basic -- we already have test coverage for these primitives in |
@oleavr Code is rebased and test added |
Thanks! 🙌 Since it took me some time to get to this, I've improved the test to test things inside CModule, and exposed some more APIs while at it. Cheers! |
I've referenced some memory functions (read, write & scan) to the cmodule runtime so that it can be invoked through cmodule scripting