Fix TLV initialization on AArch64 #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constructors may already access thread-local variables, hence we need to initialize these first, before emitting callouts to initializers.
jiska2342
changed the title
- We now store the allocated TLV area into the correct slot in the region pointed to by TPIDRRO_EL0, instead of vice versa. - tlv_get_addr_addr may be signed by Dyld; strip the signature before calling it from the runtime. - We want to skip pre-allocated pthread keys, but emitted the wrong condition. We now correctly check against the key.
|
Thanks, this is awesome! 🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a number of issues introduced in #709. Injecting a library using TLVs now works on iOS.
Tested on an iPhone 14 running iOS 16.2.1 with Dopamine.