fix(android): set DexFile to read-only in Java.registerClass() #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Android 14, apps with targetSdk >= 34 are not allowed to have writable permissions on dynamically loaded Dex files. https://developer.android.com/about/versions/14/behavior-changes-14#safer-dynamic-code-loading This removes writable permissions from the temporary DexFile created by Java.registerClass() after writing to it and before it gets loaded.
pandasauce
force-pushed
the
feature/android-14-ro-dex
branch
from
f6f146b to
42c6836
Compare
|
Nice!! Thanks! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Android 14, apps with targetSdk >= 34 are not allowed to have writable permissions on dynamically loaded Dex files.
https://developer.android.com/about/versions/14/behavior-changes-14#safer-dynamic-code-loading
Attempting to call
Java.registerClass()with such apps results in an exception being thrown:This removes writable permissions from the temporary DexFile created by
Java.registerClass()after writing to it and before it gets loaded.