portability: memcpy of size zero is undefined behaviour

frida · Jan 27, 2023 · b02ef8d · b02ef8d
1 parent 65cfe08
commit b02ef8d
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/quickjs.c b/quickjs.c
@@ -32777,8 +32777,10 @@ static JSValue js_create_function(JSContext *ctx, JSFunctionDef *fd)
             }
         } else {
             b->vardefs = (void *)((uint8_t*)b + vardefs_offset);
-            memcpy(b->vardefs, fd->args, fd->arg_count * sizeof(fd->args[0]));
-            memcpy(b->vardefs + fd->arg_count, fd->vars, fd->var_count * sizeof(fd->vars[0]));
+            if (fd->vars && fd->arg_count > 0) {
+                memcpy(b->vardefs, fd->args, fd->arg_count * sizeof(fd->args[0]));
+                memcpy(b->vardefs + fd->arg_count, fd->vars, fd->var_count * sizeof(fd->vars[0]));
+	    }
         }
         b->var_count = fd->var_count;
         b->arg_count = fd->arg_count;