Windows 11 support for getCurrentConnections (fix parsing)
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const winMajor = os.release().split('.')[0]; | ||
| const winMinor = os.release().split('.')[1]; | ||
| const winBuild = os.release().split('.')[2]; | ||
| return winMajor >= 10 && winMinor >= 0 && winBuild >= 22000; |
There was a problem hiding this comment.
Shouldn't this be winMajor >= 11? It still works because there is also the winBuild restriction though.
There was a problem hiding this comment.
Answering my own question: no, winMajor is still 10 in windows 11:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Windows 11 has two more fields in
netsh wlan show interfaces: Interface Type (ifaceType) and Band (band). This made the parsing break so.getCurrentConnections()would return its values on the wrong keys for the resulting object.Also made a few quick typo corrections.
Motivation and Context
See #176
Usage examples
Use
.getCurrentConnections()in Windows 11.How Has This Been Tested?
I tested getting the current connections and the object would now make sense.
Types of changes