Add a hook 'actionValidateOrderAfter', This hook is called after the … #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…complete creation of an order
ghost
approved these changes
Jun 15, 2021
jf-viguier
approved these changes
Jun 15, 2021
PululuK
approved these changes
Jun 15, 2021
| 'order' => $order, | ||
| 'customer' => $this->context->customer, | ||
| 'currency' => $this->context->currency, | ||
| 'orderStatus' => new OrderState($order->current_state), |
There was a problem hiding this comment.
Si nous avons déjà injecté la commande, je pense que orderStatus devrait être géré au niveau de l'implementation dans le module.
nenes25
approved these changes
Jun 15, 2021
SebSept
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
I have just read the code, not tested.
Everything is ok.
I can't see any armful stuff happening with theses changes.
The only thing I notice it that the new hook will be declared after an upgrade but not after a fresh install.
This is not a problem for me since installing a new shop using 1.6 is not recommended (I guess).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an order is created, several modules can be called by the validateOrder hook or other hooks.
There are very often problems and an order is not completely created, no status, no confirmation email sent etc... the reasons can be multiple, poorly developed module, unexpected error, call to an api that does not respond.
Linking PrestaShop to an ERP is more and more common and the exchanges must be reliable.
Also sending to an ERP can generate a change of status for the order but since it is not completely created, there can be conflicts.
This hook allows to create the order completely and then the hook is executed, sending the order to an ERP for example, allows to have the whole order with a status etc. and if the link with the ERP does not work, the order is not "corrupted".
I took the example of liaison with an ERP because I added this hook on several sites and it is very useful.