feat: Code Refactor & Upgrade to Next.js 15 / React 19-RC #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Reviewer's Guide by SourceryThis pull request performs a major upgrade to Next.js 15 and React 19-RC while significantly refactoring the codebase. The changes focus on improving component architecture, type safety, and performance through modern React patterns and better code organization. The upgrade includes configuration updates, dependency updates, and extensive component refactoring. Class diagram for new and updated componentsclassDiagram
class ProductResultView {
+ProductResultView(result: ProductResult, sources: Sources, productState: ProductState, barcode: string)
}
class ViewportScanner {
+ViewportScanner(onDetected: function, setScanning: function)
}
class IngredientsForm {
+IngredientsForm()
}
class ShareButton {
+ShareButton(productName: string, barcode: string)
}
class ModalWrapper {
+ModalWrapper(id: string, buttonType: string, buttonClass: string, buttonText: string, children: ReactNode)
}
class FooterLink {
+FooterLink(href: string, src: string, alt: string, className: string, width: number, height: number)
}
class SupportOption {
+SupportOption()
}
class NavItem {
+NavItem(href: string, iconClass: string, translationKey: string, isActive: boolean)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @philipbrembeck - I've reviewed your changes - here's some feedback:
Overall Comments:
- Great job on the refactoring! The code is cleaner and more maintainable. However, we noticed that the OLEDMode component was removed from the More page. Was this intentional?
- The improvements in code structure, especially in components like ShareButton and Modal, are commendable. Good use of React best practices and TypeScript features throughout.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@sourcery-ai review |
There was a problem hiding this comment.
Hey @philipbrembeck - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Hardcoded PayPal donation link with a specific button ID found. (link)
Overall Comments:
- Using React 19 RC and Next.js 15 in production could introduce instability. Consider waiting for stable releases or thoroughly testing these pre-release versions.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Will be included later on in the README
|
@sourcery-ai review |
There was a problem hiding this comment.
Hey @philipbrembeck - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Potential hard-coded PayPal donation link detected. (link)
Overall Comments:
- The OLED mode component was removed from the more page without explanation. Was this intentional? If so, please document the reasoning for this change.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
The update to Next.js 15 still breaks the Which is allegedly fixed in We should test the impact of this on staging. @sourcery-ai review |
philipbrembeck
changed the title
|
@sourcery-ai review |
There was a problem hiding this comment.
Hey @philipbrembeck - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using the latest stable React 18 version instead of React 19 RC for production use. While the RC may work, it's generally safer to wait for the stable release before upgrading.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
philipbrembeck
changed the title
|
@sourcery-ai review |
There was a problem hiding this comment.
Hey @philipbrembeck - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Potential hard-coded PayPal donation link found. (link)
Overall Comments:
- The removal of documentation files (/docs/*) should be addressed - please provide an alternative documentation solution or restore these files to maintain project documentation.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@sourcery-ai review |
There was a problem hiding this comment.
Hey @philipbrembeck - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Potential hard-coded PayPal donation link found. (link)
Overall Comments:
- Consider adding unit tests for the new refactored components to maintain test coverage, particularly for the ViewportScanner and ProductResultView components.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Upgrade the project to Next.js 15 and React 19-RC, refactoring components for improved modularity and performance. Introduce new components for barcode scanning and product result display, and enhance sharing functionality. Update build and CI configurations to align with the latest dependencies and Node.js version.
New Features:
ViewportScannercomponent for barcode scanning with camera switching capabilities.ProductResultViewcomponent to display product details including vegan status, nutriscore, and grade.ShareButtoncomponent for sharing product details across various platforms.Enhancements:
ShareButtoncomponent to use a more modular and maintainable approach withuseMemo.Footercomponent by introducing aFooterLinksub-component for better reusability.ModalWrappercomponent to useuseCallbackanduseReffor better performance and readability.Build:
pnpm-lock.yaml.CI:
Tests: