Skip to content

Commit

Permalink
Attempt to add protobuf dependency installation on macos-11
Browse files Browse the repository at this point in the history
Since the Qt5 build seems failing because protobuf is not found
/tmp/qt-20231104-5483-1fey0cz/qt-everywhere-src-6.5.2/qtgrpc/src/tools/qtprotoccommon/generatorbase.cpp:8:10: fatal error: 'google/protobuf/stubs/logging.h' file not found
  • Loading branch information
fspindle committed Nov 8, 2023
1 parent c30d265 commit 9d4d18f
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 15 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/macos-ustk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,13 @@ jobs:
- name: Print OS information
run: system_profiler SPSoftwareDataType

- name: Install dependencies
run: brew install libpng libjpeg-turbo libdc1394 opencv pcl librealsense zbar vtk fftw armadillo nlohmann-json
- name: Install dependencies for macos-11
if: matrix.os == 'macos-11'
run: brew install libpng libjpeg-turbo libdc1394 opencv pcl librealsense zbar pkg-config nlohmann-json protobuf

- name: Install dependencies for macos-12
if: matrix.os == 'macos-12'
run: brew install libpng libjpeg-turbo libdc1394 opencv pcl librealsense zbar pkg-config nlohmann-json

- name: Clone visp-images
env:
Expand Down
19 changes: 6 additions & 13 deletions .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,12 @@ jobs:
- name: Print OS information
run: system_profiler SPSoftwareDataType

- name: Install dependencies
- name: Install dependencies for macos-11
if: matrix.os == 'macos-11'
run: brew install libpng libjpeg-turbo libdc1394 opencv pcl librealsense zbar pkg-config nlohmann-json protobuf

- name: Install dependencies for macos-12
if: matrix.os == 'macos-12'
run: brew install libpng libjpeg-turbo libdc1394 opencv pcl librealsense zbar pkg-config nlohmann-json

- name: Install java dependencies
Expand Down Expand Up @@ -87,18 +92,7 @@ jobs:
make -j$(sysctl -n hw.logicalcpu)
- name: ViSP as 3rdparty with visp.pc and pkg-config
if: matrix.os != 'macOS-10.15'
run: |
# With macOS 10.15 there is the following build error:
# /Applications/Xcode_12.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/cmath:317:9:
# error: no member named 'signbit' in the global namespace
# using ::signbit;
# also reported here https://stackoverflow.com/questions/58313047/cannot-compile-r-packages-with-c-code-after-updating-to-macos-catalina
# As suggested adding -isysroot build flag in VISPGenerateConfigScript.cmake around line 149 with
# execute_process(COMMAND xcrun --show-sdk-path
# OUTPUT_VARIABLE SDK_PATH OUTPUT_STRIP_TRAILING_WHITESPACE)
# list(APPEND _cxx_flags "-isysroot ${SDK_PATH}")
# doesn't fix the build issue. That's why here the test is only done for macOS 11.0
cd ${HOME}/visp_sample
export PKG_CONFIG_PATH=$PKG_CONFIG_PATH:/tmp/usr/local/lib/pkgconfig
pkg-config --cflags visp
Expand All @@ -107,7 +101,6 @@ jobs:
make -j$(sysctl -n hw.logicalcpu) -f Makefile.visp.pc clean
- name: ViSP as 3rdparty with visp-config
if: matrix.os != 'macos-10.15'
run: |
cd ${HOME}/visp_sample
export PKG_CONFIG_PATH=$PKG_CONFIG_PATH:/tmp/usr/local/lib/pkgconfig
Expand Down

0 comments on commit 9d4d18f

Please sign in to comment.