Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality test #36

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Functionality test #36

merged 1 commit into from
Apr 23, 2024

Conversation

ssyssy
Copy link
Collaborator

@ssyssy ssyssy commented Apr 22, 2024

No description provided.

@ssyssy ssyssy changed the base branch from main to dev April 22, 2024 20:38
@ssyssy ssyssy force-pushed the functionality-test branch 2 times, most recently from 8f9f0a9 to c2b725f Compare April 22, 2024 21:13
@ssyssy ssyssy force-pushed the functionality-test branch 2 times, most recently from 33f613e to 7043286 Compare April 22, 2024 22:43
@LuQQiu
Copy link
Collaborator

LuQQiu commented Apr 22, 2024

Every test has its own designed usage
can you add the test cases to another general functionality test focus test instead of keep adding to the existing cat_file test

@LuQQiu LuQQiu changed the base branch from dev to main April 22, 2024 23:10
@ssyssy ssyssy force-pushed the functionality-test branch 2 times, most recently from 312f8ca to 3127c4c Compare April 22, 2024 23:21
@ssyssy ssyssy requested a review from LuQQiu April 22, 2024 23:21
@LuQQiu
Copy link
Collaborator

LuQQiu commented Apr 22, 2024

@ssyssy Cat test was added for testing the intense cat operations

    for _ in range(NUM_TESTS):
        offset = random.randint(0, file_size - 1)
        length = min(random.randint(1, file_size - offset), max_length)
        validate_read_range(
            alluxio_file_system,
            alluxio_path,
            local_path,
            offset,
            length,
        )

    LOGGER.debug(
        f"Data matches between Alluxio file and local source file for {NUM_TESTS} times"
    )

    special_test_cases = [
        (file_size - 1, -1),
        (file_size - 1, file_size + 1),
        (file_size, 100),
    ]

can you keep it as it is?

Basic functionality test can be in other test classes

@ssyssy ssyssy force-pushed the functionality-test branch from 3127c4c to cff44dc Compare April 22, 2024 23:44
@ssyssy ssyssy force-pushed the functionality-test branch from cff44dc to 763f605 Compare April 22, 2024 23:46
Copy link
Collaborator

@LuQQiu LuQQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssyssy ssyssy merged commit f6cea96 into main Apr 23, 2024
3 checks passed
@ssyssy ssyssy deleted the functionality-test branch April 23, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants