-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: hyperlink registry #442
base: master
Are you sure you want to change the base?
Conversation
couldn't get the hyperlink to work. I belive because https://filesystem-spec.readthedocs.io/en/latest/_modules/fsspec/registry.html isn't part of the API. |
Feel free to add it. The registry could probably do with more work to include searching for entrypoints anyway. |
bit unsure where to put it. Dropped it in Built-in Implementations but not sure if
|
A couple of possible solutions for directly including the dictionary: https://stackoverflow.com/questions/27875455/displaying-dictionary-data-in-sphinx-documentation/29789910 |
(ping) |
@@ -55,7 +55,7 @@ The current list of known implementations can be found as follows | |||
known_implementations | |||
|
|||
These are only imported on request, which may fail if a required dependency is missing. The dictionary | |||
``fsspec.registry`` contains all imported implementations, and can be mutated by user code, if necessary. | |||
:py:class:`fsspec.registry.known_implementations` contains all imported implementations, and can be mutated by user code, if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, on second reading, this is wrong. fsspec.registry
is indeed the set of classes that have been used so far: the values are python class objects. known_implementations
is a dictionary where the values are dictionaries of import details, location of the class and reasonable error messages - it serves as the source of the classes for registry
via fsspec.get_filesystem_class
, but you could edit either one at runtime.
Sorry, this seems to have got lost. Still interested? |
I test locally later.
You can add a rtd build check using the site (click button at botton of image)