fix(embed): escape dollar symbol of JSON string literal

fujidaiti · Jun 14, 2024 · 648ff8e · 648ff8e
1 parent 894ada9
commit 648ff8e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/embed/lib/src/literal/dart_literals.dart b/embed/lib/src/literal/dart_literals.dart
@@ -72,7 +72,7 @@ class StringLiteral extends DartLiteral<String> {
 
   @override
   String toString() {
-    final literal = value.replaceAll('"', r'\"');
+    final literal = value.replaceAll('"', r'\"').replaceAll(r'$', r'\$');
     return '"$literal"';
   }
 }

diff --git a/embed/test/literal/literal_embedding_generator_test.dart b/embed/test/literal/literal_embedding_generator_test.dart
@@ -243,3 +243,14 @@ const _$mapPattern = {"a": 0, "b": 0.0, "c": true};
 """,
 )
 Map<String, dynamic>? mapPattern;
+
+@TestEmbedLiteral(
+  extension: "json",
+  content: r"""
+{ "dollar": "$" }
+""",
+  shouldGenerate: r"""
+const _$stringLiteralsDollar = (dollar: "\$");
+""",
+)
+var stringLiteralsDollar;