feature: support IUPAC bases - attempt 2 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nh13
commented
Feb 18, 2025
| @@ -0,0 +1,571 @@ | |||
| // Copyright 2014-2016 Johannes Köster. | |||
There was a problem hiding this comment.
Pulled directly from rust-bio so we don't have to have it as a full dependency.
nh13
commented
Feb 18, 2025
| self.len == 0 | ||
| } | ||
|
|
||
| /// Calculate the Hamming distance between this and another bitencoded sequence. |
nh13
commented
Feb 18, 2025
| } | ||
|
|
||
| #[test] | ||
| fn test_hamming() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #53
I found that
bio-seqwas significantly slower than usingbitencfrombiowhen there were A LOT of barcodes that didn't match. Rather than pulling in all of rust-bio, I copiedbitencfrom rust-bio, then added thehammingmethod (that's slightly faster than our current method) and associated tests.