No longer raise a RuntimeError if an input file was not formatted wel… #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l. It is quite normal to accept such input. Also log 'Fixed it for you' in case a file has been fixed by gherkin_format.
|
This should fix #5 |
|
How to run this script in CI? It is a valid requirement to see if there are unformatted files. How to do this without the exit code? |
|
Thanks, I see what you mean, and now made sure the error code 1 will be returned to be usable in CI environments. Now the issue #5 should be fixed without bad side-effects, if you merge this PR. Cheers! |
|
Wie merged man das jetzt? |
lindt
requested changes
Jul 22, 2018
lib/gherkin_format.rb
Outdated
| File.write(file, output) if options.key? :replace | ||
| if options.key? :replace | ||
| File.write(file, output) | ||
| puts "File #{file} was not formatted well. Fixed it for you!" |
|
ping! fixed your review findings; now also multiple files can be fixed by gherkin_format before exiting with status 1. |
|
ping |
1 similar comment
|
ping |
|
piing |
|
pong |
|
ping |
|
ping, mate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l. It is quite normal to accept such input. Also log 'Fixed it for you' in case a file has been fixed by gherkin_format.