Test unit test fixes #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed annotation. Re-add missing unit tests from merge.
Remove few more deprecated methods Also did minor changes in DynamoDBLeaseRefresherTest
…nd CooridnatorStats table
1. remove LeaderDecider.isAnyLeaderElected - this was needed for archiver migration not needed for public changes which does auto flip based migration 2. Make DeterministicShuffleShardSyncLeaderDecider package scope - this was also made public scope for archiver migration, not needed for public repo.
There is no migration test currently with embedded ddb But we do test Lease refresher with embedded ddb that when createGSI and waitForGSIToBeActive is invoked it creates-but-not-wait and waits-for-gsi-to-be-active respectively. So its good enough to ensure those APIs are invoked from migration state machine. So just added a few more verifications to existing tests.
furq-aws
force-pushed
the
kclv3-off-master
branch
from
9a11fba to
ebb7dd9
Compare
Dont use jitter for periodic scheduling, just for start time of the clientVersionChangeMonitor so that the metrics looks more consistent
Using initial delay as interval + jitter so during state transition the metrics wont be double emitted. only down side is that during startup the metrics will be delayed by upto 1.5 mins, which is not too bad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.