Make Point Light radius modifiable

[howetuft]

Currently, Point Light radius is hard-coded to 50mm, which can be somewhat huge for certain scenes (for instance, a scene containing small parts...). I propose you to let the radius be initialized to 50mm, but to make it modifiable afterwards via the GUI.

[luzpaz]

@furti care to weigh in on this?

[furti]

Completely missed this pull request. Sorry for this.

It looks good to me. I will try to merge it this week. I'm ptetty busy at the moment.

[howetuft]

Thank you very much. By the way, I may send you some others in the next days!

[howetuft]

Hi Furti, I pushed a new commit to add a RenderingPower property on point lights: it is needed for physically-based renderers (lux, appleseed, cycles...).
I also rebased my work (therefore you can see commits from Luzpaz.
May you please merge this?
Thanks in advance!

[furti]

@howetuft as i asked before. Why do we need the same setting twice? For me "rendering power" sounds a lot like "intensity".

If the reason is we should have a unconstraint intensity setting, we should remove it and calculate the intensity for coin based on the RenderingPower.

Having it twice will lead to some confusion i think.

I would also call it "power" without the "rendering" predix then.

[howetuft]

Yes, the main reason is that OI Intensity is upper bounded, whereas Power is not, and I cannot figure out how to map a unbounded value to a bounded one (see my post: https://forum.freecadweb.org/viewtopic.php?f=10&t=40623#p346806).

we should remove it and calculate the intensity for coin based on the RenderingPower.

I agree: for instance, we could link Intensity to power with something like Intensity = min(1,Power/K) (K being a constant, for instance K=100) and hide Intensity to the user.
Do you agree with that?

I would also call it "power" without the "rendering" predix then.

Sure! I can push a commit soon for that.

[furti]

for instance, we could link Intensity to power with something like Intensity = min(1,Power/K) (K being a constant, for instance K=100) and hide Intensity to the user.
Do you agree with that?

Yes this is what I had in mind. You have more experience with the different renderers. So maybe there is a value K that gives a similar result for the intensity in FreeCAD like it would give in the supported renderers. So e.g. the maximum value for RenderingPower someone would ever set in a Renderer is 10000, than using 10000 for K might be a good choice.

[howetuft]

Hi @furti,
As a follow-up to our exchange 2 days ago, I wrote some code to implement a single Power attribute in place of Intensity and RenderingPower:

• RenderingPower is now removed.
• Intensity I kept, but in the background, relinked to Power. I wrote something that should ensure backward compatibility (for already created point lights). Note: I finally set K to 100...

My commit is above...
Thanks!

[howetuft]

Hello @furti,
I hope I find you well!
Have you had time to look at my last comments above?
The PRs I proposed for point lights in the Render workbench are merged now, but they require point lights to bear a Power property...
Would it be possible for you to please give me some feedback, or even merge my commits?
Thank you in advance!