Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOMクラスにtransformメソッドを追加 #110

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

SOMクラスにtransformメソッドを追加 #110

wants to merge 5 commits into from

Conversation

ae14watanabe
Copy link
Member

@ae14watanabe ae14watanabe commented Dec 4, 2019 •
edited
Loading

** Description 説明 **
close #109

** Type of change 変更の種類**

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested? どのようにテストしたか？

tests/som/test_som.py内にfitの潜在変数推定結果とtransformでの潜在変数結果が一致するかどうか確認するメソッドを作成。実行しpassを確認。

@ae14watanabe ae14watanabe added enhancement New feature or request good first issue Good for newcomers labels Dec 4, 2019
@ae14watanabe ae14watanabe self-assigned this Dec 4, 2019
@ae14watanabe ae14watanabe mentioned this pull request Dec 4, 2019
Open
1 task
TetraMiyazaki
TetraMiyazaki approved these changes Apr 11, 2020
View reviewed changes
Copy link
Contributor

@TetraMiyazaki TetraMiyazaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

なんか当然のことをやっている気がするのですが，
transformっていうメソッドが必要だった感じっぽいですね
テストはしましたのでapproveします．

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TetraMiyazaki TetraMiyazaki TetraMiyazaki approved these changes

@noguchikazuki noguchikazuki Awaiting requested review from noguchikazuki

Assignees

@ae14watanabe ae14watanabe

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SOMクラスにtransformメソッドの追加
2 participants
@ae14watanabe @TetraMiyazaki