Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#155 tsom.pyの学習過程の関数化 #157

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

forusufia
Copy link
Contributor

@forusufia forusufia commented Jun 6, 2020

close #155

** Description 説明 **
tsom.py の学習を、som.py と同様に協調過程、適応過程、競合過程の3ステップで関数化した。
なお、欠損値への対応と直接型・一次モデル型の選択があるため、適応過程と競合過程はそれぞれ4種ずつになる。

** Type of change 変更の種類**

  • Breaking change (fix or feature that would cause existing functionnality not to work as expected)

** How Has This Been Tested? どのようにテストしたか?**
test/tsom/test_missing_TSOM.pyを実行しtestした.

  • 変更後の関数化されたtsom: libs/models/tsom.py
  • 変更前の関数化されていないtsom: libs/models/tsom2_ishida.py

Reviewerにやって欲しいこと

test/tsom/test_missing_TSOM.pyを実行しtestをpassすることを確かめる

@forusufia forusufia added the enhancement New feature or request label Jun 6, 2020
@forusufia forusufia self-assigned this Jun 6, 2020
@takuro-Ishida takuro-Ishida changed the title #155 tsom learning functionalization #155 tsom.pyの学習過程の関数化 Jun 6, 2020
@takuro-Ishida
Copy link
Member

test/tsom/test_missing_TSOM.pyを実行し,testをpassしました
image

@takuro-Ishida takuro-Ishida self-requested a review June 6, 2020 07:40
takuro-Ishida
takuro-Ishida previously approved these changes Jun 6, 2020
Copy link
Member

@takuro-Ishida takuro-Ishida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testをpassしたのでApproveします

@forusufia forusufia requested a review from takanoshuhei June 6, 2020 07:43
@ae14watanabe
Copy link
Member

この変更って

Breaking change (fix or feature that would cause existing functionnality not to work as expected)

ではないと思うよ。既存のtestを実行してpassするか確認するのはそういうことよね。

@takuro-Ishida takuro-Ishida self-requested a review June 21, 2020 08:14
Copy link
Member

@takuro-Ishida takuro-Ishida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/tsom/test_missing_TSOM.pyを実行し,testををpassしたのを確認したのでApproveします
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tsom.py の学習をステップごとに関数化する
3 participants