Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(weak change)gitignoreを修正 #170

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

TetraMiyazaki
Copy link
Contributor

** Description 説明 **

gitignoreを修正しました

** Type of change 変更の種類**

  • New feature (non-breaking change which adds functionality)

@TetraMiyazaki
Copy link
Contributor Author

weak changeなのでしゃしゃっとapproveでいいと思います.お願いします.

@TetraMiyazaki TetraMiyazaki changed the title weak change/gitignoreを修正 (weak change)gitignoreを修正 Jan 1, 2021
tsuno0829
tsuno0829 previously approved these changes Jan 1, 2021
Copy link
Member

@tsuno0829 tsuno0829 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題ないと思うのでapproveします!

Copy link
Member

@tanacchi tanacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここに登録されていない __pycache__ とかって皆さんどうされているのですかね.

これを機に,Python 用の 公開 .gitignore にあるものも
追加してしまうのはいかがでしょうか.

@tanacchi
Copy link
Member

tanacchi commented Jan 1, 2021

追加してしまいました.

被りがないかも確認しております.

@tanacchi
Copy link
Member

tanacchi commented Jan 1, 2021

私が commit したことで
@tsuno0829 さんの approve が dismiss されたみたいです…
申し訳ありませんがまた確認いただきたいです.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants