単項演算子をサポート #131
Open
単項演算子をサポート #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanzaku
requested changes
Feb 28, 2025
| @@ -52,7 +52,8 @@ impl UnaryExpr { | |||
|
|
|||
| result.push_str(&self.operator); | |||
| // `NOT` のときは空白が必要 | |||
| if self.operator.to_uppercase() == "NOT" { | |||
| // `@`（絶対値）のときも空白が必要（PostgreSQLでは、`@-` とすると一つのトークンとして扱われてしまうため） | |||
| if self.operator.to_uppercase() == "NOT" || self.operator.to_uppercase() == "@" { | |||
There was a problem hiding this comment.
@ の方は to_uppercase 不要かと思います。
lemonadern
force-pushed
the
pgcst--unary-expr
branch
from
04254dc to
2e0b34e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
式のうち、単項の演算子をサポートしました
Note
PostgreSQLの絶対値演算子(
@)について、@-5のように他の演算子と並べて記述すると@-という一つの演算子と認識される挙動がありますが、現行フォーマッタのテストケースではこの点を考慮しないフォーマットをしていたため挙動を変更しました。commit: baae324
パーサ移行によって解消される問題としてIssueに起こしました：#132