* Fix increasing scrolling error of scrollBy by compensation #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction with different writing modes.
…-container and iframe for scrollbar.
|
Hey! Thank you! It worked for me <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
`scrollBy' in this file
epub.js/src/managers/default/index.js
Line 829 in a1e77b7
operates scrollLeft or scrollTop for moving to previous or next page.
However, the document
https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollLeft
said: "On systems using display scaling, scrollLeft may give you a decimal value."
Thus, operations on scrollLeft or scrollTop could be not precise!
E.g., this.container.scrollTop is 0 and y is 100, after this.container.scrollTop += y, this.container.scrollTop might become 99.xxx!
The worse problem is this error increases with increasing prev() or next(). It can result in this kind of page shift problem:
With the compensation algorithm in this pull request branch, the problem is alleviated!
This compensation algorithm works also for horizontal writing ePub. E.g, the one without compensation:
The one with compensation: