-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test epub #1284
Draft
kmacshane
wants to merge
18
commits into
futurepress:master
Choose a base branch
from
eSpark:test-epub
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Test epub #1284
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5df5664
add test reader
kmacshane 23d298c
trying to add media overlays
kmacshane 4f4c112
got the audio to be added to the page
kmacshane 5c3c6d3
removed comments
kmacshane 72a036a
Update section.js
kmacshane 91dd9e9
moving changes from epub to classes
kmacshane a529a92
Update reader.js
kmacshane e99472b
Update section.js
kmacshane b38a88d
Update section.js
kmacshane 5afdb42
comments regarding URLs
kmacshane f381e6a
Update resources.js
kmacshane e4d4543
Update replacements.js
kmacshane 33ed9a5
Update reader.js
kmacshane 045bffe
added code to get list of audio clips on page load
kmacshane d37aac7
replace audio URLS for testing
kmacshane d2c4d5b
adding howler
kmacshane 4a791cb
getting highlighter function to work
kmacshane d215eed
added audio updates
kmacshane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main change in section is that instead of loading just the page url, I also load the smil file first and then feed the result into where it loads the main page, in order to append it onto the iframe html.