Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPD-309] Update stack set to add individual modules to the matcha.config.json file #210

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

JonoCX
Copy link
Member

@JonoCX JonoCX commented Aug 30, 2023

This PR updates the stack_set function such that the components of the respective stacks (default and llm) are included in the matcha.config.json.

To do this, the PR introduces two constants: DEFAULT_STACK and LLM_STACK. The contents of these constants are then added to MatchaConfigComponent, along with the name. The tests have been refactored to reflect this change.

I have also updated the name of the original DEFAULT_STACK and LLM_STACK in matcha_ml.templates.azure_template to DEFAULT_STACK_TF and LLM_STACK_TF respectively. This is to avoid a naming conflict and the newer constants more actually describe the stack.

Checklist

Please ensure you have done the following:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation if required.
  • I have added tests which cover my changes.

Type of change

Tick all those that apply:

  • Bug Fix (non-breaking change, fixing an issue)
  • New feature (non-breaking change to add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@JonoCX JonoCX added the enhancement New feature or request label Aug 30, 2023
@JonoCX JonoCX self-assigned this Aug 30, 2023
Copy link
Member

@Christopher-Norman Christopher-Norman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, nice work. Added a single comment as an FYI but is irrelevant to this PR.

Comment on lines +20 to 23
LLM_STACK_TF = DEFAULT_STACK_TF + [
"chroma",
"chroma/chroma_helm",
"chroma/chroma_helm/templates",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: LLM_STACK_TF and DEFAULT_STACK_TF will become redundant with the modular implementation. I have created tickets for their removal and updating wherever they are used 👍

Copy link
Contributor

@swells2020 swells2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@JonoCX JonoCX merged commit ccf2e79 into feature/modular-stacks Aug 31, 2023
@JonoCX JonoCX deleted the RPD-309-update-stack-set branch August 31, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants