Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPD-315] Update provisioning/destroy message for modular stack #213

Merged
merged 6 commits into from
Sep 1, 2023

Conversation

JonoCX
Copy link
Member

@JonoCX JonoCX commented Sep 1, 2023

As we've introduced modular stacks, with differing components, the provisioning and destroy resources message that's presented to the user is incorrect - it's missing components.

This PR updates the generation of that message such that it's dynamically generated based on the stack that has been set by the user.

The get_stack() function has also been updated to streamline the dynamic generation. Previous, just the name was returned, now the whole stack component is returned.

Checklist

Please ensure you have done the following:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation if required.
  • I have added tests which cover my changes.

Type of change

Tick all those that apply:

  • Bug Fix (non-breaking change, fixing an issue)
  • New feature (non-breaking change to add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@JonoCX JonoCX added the enhancement New feature or request label Sep 1, 2023
@JonoCX JonoCX self-assigned this Sep 1, 2023
Copy link
Member

@Christopher-Norman Christopher-Norman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work.

@JonoCX JonoCX merged commit 8aa4dd3 into feature/modular-stacks Sep 1, 2023
@Christopher-Norman Christopher-Norman deleted the RPD-315-update-resource-msg branch September 4, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants