Needed choice on python 2.6 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents the AttributeError concerning the version dependent code when running on python 2.6
Fixed an exception occuring when pressing 'b' on a Menu with only a list of choices Example classes are now working on python 2.6 as well
Proposing a new version of the package because I need it. The intention of the c used in the version is to make sure it's considered an older version when the original author creates the real version 0.2
Can now test on python 2.6 too
| # Get a yes or no response (default is no) | ||
| confirm = choice.Binary('Are you sure you want to delete?', False).ask() | ||
| if confirm: | ||
| deleteIt() | ||
| c() |
There was a problem hiding this comment.
Hey @bastbnl, any reason to put this in a separate c() function rather than just inline? Seems to me that just writing print("Delete confirmed") here would work too.
There was a problem hiding this comment.
No particular reason. I noticed confirming the question stops the test script as the function is undefined. A separate function is not required at all and printing a message would make sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so I went ahead and created some changes to see that it works on python 2.6 as well. I also replaced the \n in the code to os.linesep, allowing this to work properly on non-Unix systems as well.
I've performed some basic tests (Menu with choices, Menu with choices and actions, Input with int, Binary with default False) but it's probably a good idea to verify that it still works properly on python 2.7 and 3 as well
Thanks for a pretty useful module.