Fix/revert render dupe #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows us to remove the duplicated renderer so we can get benefits of new textgrid features
|
I opened this as a PR so that @mgazza could review it if time is available. Otherwise I'll land it at the end of the week and see if we can rebase some of the other feature additions on top of this slimmer TextGrid. |
|
Hi Andy, I'm currently away on annual leave.
I'll be back next Monday.
Thanks,
Mark
…On Mon, 20 Jan 2025, 11:43 Andy Williams, ***@***.***> wrote:
I opened this as a PR so that @mgazza <https://github.com/mgazza> could
review it if time is available.
Otherwise I'll land it at the end of the week and see if we can rebase
some of the other feature additions on top of this slimmer TextGrid.
—
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD3ZWQ6PGE65QOSZ6CHEXJL2LTOM7AVCNFSM6AAAAABVQFNOASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBSGIYDCMJYHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Landing this so master is in a better state - some reports of slowness due to the partial thread changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing code that gets in the way of us getting new features from upstream.
I also reverted our move to develop just now - threading changes need work and I can do that on a separate PR.