Fix possible crash when URI parse fails #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacalz
reviewed
Dec 31, 2023
| @@ -31,7 +31,7 @@ func (t *Terminal) handleOSC(code string) { | |||
|
|
|||
| func (t *Terminal) setDirectory(uri string) { | |||
| u, err := storage.ParseURI(uri) | |||
| if err == nil { | |||
| if err != nil { | |||
| // working around a Fyne bug where file URI does not parse host | |||
There was a problem hiding this comment.
Is there an upstream bug tracking this?
There was a problem hiding this comment.
I'm not sure if it is still an issue or what the details are - it was so long ago.
But it doesn't relate to this fix ironically - the issue here was that it was using the url when the parse failed instead of when it succeeded...
|
No objections in a week... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally tracked down what could have caused the macOS reports
Fixes #40