Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose an easy way to run a function upon terminal window change #62

Closed
wants to merge 5 commits into from

Conversation

figuerom16
Copy link
Contributor

This currently modifies RunWithConnection which is a breaking change.
Should this be split out into another function like OnWindowChange?

Returning the rows and cols through the function is nice since those weren't exposed before.

@andydotxyz
Copy link
Member

Returning the rows and cols through the function is nice since those weren't exposed before.

I don't understand - the AddListener returns a chan of Config that includes Rows and Cols as exposed fields already...

@figuerom16
Copy link
Contributor Author

My apologies. I made this and #57 more complicated than needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants