Add word selection on double-tap #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgazza
force-pushed
the
doubleclick-highlight-word
branch
2 times, most recently
from
e27253f to
5bcf9ed
Compare
andydotxyz
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Please avoid the self-evident comments. It's adding nearly 20% more lines to the source
It feels like some of this selection code could be factored out of the double tap handler method too, to keep methods shorter and more succinct - and less need for comments ;)
|
no problem i'll remove the comments :D |
Implement word selection functionality triggered by a double-tap. Words are identified as sequences of alphanumeric characters, while spaces and punctuation are ignored. Update the selection logic to highlight the word under the cursor and clear any existing selection. Adjust tests to validate word selection and ensure accurate behavior when tapping on non-alphanumeric characters.
mgazza
force-pushed
the
doubleclick-highlight-word
branch
from
5bcf9ed to
07c62e2
Compare
andydotxyz
requested changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement word selection functionality triggered by a double-tap. Words are identified as sequences of alphanumeric characters, while spaces and punctuation are ignored. Update the selection logic to highlight the word under the cursor and clear any existing selection. Adjust tests to validate word selection and ensure accurate behavior when tapping on non-alphanumeric characters.