Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build documentation with mkdocs #321

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

DavUhll
Copy link
Contributor

@DavUhll DavUhll commented Sep 28, 2023

Proposal for documentation with mkdos.

This PR is shows how to use mkdocs to create static documentation which can be later used in CI and host on GitHub pages.

There a quiet some changes in the folder structure, since all the README.md are now located in the docs folder.
Maybe not every link is updated correctly.

How to build docs locally:
pip install -r docs/requirements.txt
mkdocs serve

@DavUhll
Copy link
Contributor Author

DavUhll commented Sep 28, 2023

Let's start fancy stuff with mkdocs @m-naumann 😄

@m-naumann
Copy link
Member

Awesome 🚀 Thanks!

Would you mind adding a CI pipeline for that in your fork, such that we could have a look at the outcome more easily? 😃

Should be just a few lines, I did that here for example. Also, in case people do not like the moving and we don't have too much trouble with links, we could copy the stuff into docs in CI only, as I did there for some stuff.

@DavUhll
Copy link
Contributor Author

DavUhll commented Sep 28, 2023

Awesome 🚀 Thanks!

Would you mind adding a CI pipeline for that in your fork, such that we could have a look at the outcome more easily? 😃

Should be just a few lines, I did that here for example. Also, in case people do not like the moving and we don't have too much trouble with links, we could copy the stuff into docs in CI only, as I did there for some stuff.

Makes sense. I will check if this is also possible here 👍

@DavUhll DavUhll force-pushed the mkdocs branch 6 times, most recently from b1bdfac to 55de909 Compare October 1, 2023 14:28
@m-naumann
Copy link
Member

@DavUhll I added deployment and deployed to https://m-naumann.github.io/Lanelet2-1/, you can merge https://github.com/m-naumann/Lanelet2-1/tree/master into your branch for this update.

Looks nice at the first glance, however some links are broken (hard to fix since they either match the repo or the deployed docs, I guess), and the edit function is broken due to copying the files. But maybe we can go with this for the start. WDYT @immel-f @poggenhans?

@immel-f
Copy link
Contributor

immel-f commented Oct 4, 2023

Looks very nice, thanks 👍
I browsed a bit through the deployed version and only found links that point to the repo instead of the website. If that is the only problem, I think we can go with this for now since it is already a big improvement to the existing docs interface

@DavUhll
Copy link
Contributor Author

DavUhll commented Oct 9, 2023

@DavUhll I added deployment and deployed to https://m-naumann.github.io/Lanelet2-1/, you can merge https://github.com/m-naumann/Lanelet2-1/tree/master into your branch for this update.

Looks nice at the first glance, however some links are broken (hard to fix since they either match the repo or the deployed docs, I guess), and the edit function is broken due to copying the files. But maybe we can go with this for the start. WDYT @immel-f @poggenhans?

@m-naumann Thanks for the commit. I've added your commit to this PR.
@immel-f if you agree, I would open this PR and then open a follow up PR to fix all the links to link to the documentation.

let me know what you think about it.

@immel-f
Copy link
Contributor

immel-f commented Oct 13, 2023

@DavUhll I added deployment and deployed to https://m-naumann.github.io/Lanelet2-1/, you can merge https://github.com/m-naumann/Lanelet2-1/tree/master into your branch for this update.
Looks nice at the first glance, however some links are broken (hard to fix since they either match the repo or the deployed docs, I guess), and the edit function is broken due to copying the files. But maybe we can go with this for the start. WDYT @immel-f @poggenhans?

@m-naumann Thanks for the commit. I've added your commit to this PR. @immel-f if you agree, I would open this PR and then open a follow up PR to fix all the links to link to the documentation.

let me know what you think about it.

Sounds great, I am not sure however what to do to fix the links since as I understood it, either the doc or repo links will be broken 😅

What url will the docs be deployed to? We should probably also add a link to the readme before merging.

@immel-f
Copy link
Contributor

immel-f commented Nov 7, 2023

Is this PR ready for merging? I think it would make a very nice addition. If you know to which URL the docs will be deployed to it would be helpful to add a link to the readme as well.

@DavUhll
Copy link
Contributor Author

DavUhll commented Jan 3, 2024

Is this PR ready for merging? I think it would make a very nice addition. If you know to which URL the docs will be deployed to it would be helpful to add a link to the readme as well.

I've updated the README.md.

@DavUhll DavUhll marked this pull request as ready for review January 3, 2024 14:38
README.md Outdated Show resolved Hide resolved
Co-authored-by: Maximilian Naumann <[email protected]>
@m-naumann
Copy link
Member

Looks good to me now: https://m-naumann.github.io/Lanelet2-1/

README.md Outdated Show resolved Hide resolved
Co-authored-by: Maximilian Naumann <[email protected]>
@m-naumann
Copy link
Member

pinging again 😉

@immel-f
Copy link
Contributor

immel-f commented Jan 29, 2024

Thanks for the reminder 😅

@immel-f immel-f merged commit 4311fa7 into fzi-forschungszentrum-informatik:master Jan 29, 2024
9 checks passed
@DavUhll DavUhll deleted the mkdocs branch January 30, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants