Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing to_python converter for ConstWeakLanelet #331

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

brandesjj
Copy link
Contributor

First of all: thanks for the great work!
I was playing around with the Python API and loading RightOfWay Objects from the sample map.
However, access to the 'right_of_way' and 'yield' keys of the parameters attribute of the RightOfWay Object was not possible due to a missing to_python converter for ConstWeakLanelet.
I'm not sure whether this was intentional or not.

However - I added it, direct access through the parameters attribute now works and shows the same results as calling the rightOfWayLanelets() method. Same goes for the 'yield' key and yieldLanelets() method.

This is related to #233

@immel-f
Copy link
Contributor

immel-f commented Feb 7, 2024

Thanks for the fix! This was likely an oversight 👍

@immel-f immel-f merged commit 4789fde into fzi-forschungszentrum-informatik:master Feb 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants