Skip to content

Commit

Permalink
resolving conflicts
Browse files Browse the repository at this point in the history
  • Loading branch information
costero-e committed Dec 12, 2024
2 parents 09143f2 + e7ca12a commit 724b65c
Show file tree
Hide file tree
Showing 135 changed files with 1,575 additions and 743 deletions.
11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,18 @@ There is a set of tools in [`/bin`](./bin/) to facilitate the conversion. ATM, a

### Changelog

## 2.1.1

*Released, October, 8, 2024*
[Beacon-v2.1.1](https://github.com/ga4gh-beacon/beacon-v2/tree/5ea17fbd0d2ba533aa1e85f7271f9a2cc9be6794)

* Changed uri for uri-template in Endpoint.singleEntryUrl


## 2.1.0

*Released, July, 19, 2024*
[Beacon-v2.1.0](https://github.com/ga4gh-beacon/beacon-v2/tree/16862205c79294fae5473f7fa330bf5929b3b120)

* Relocated TypedQuantity required to proper level of the schema for complexValue
* Added end and start entities for ageRange and iso8601duration for age
Expand All @@ -41,6 +50,7 @@ There is a set of tools in [`/bin`](./bin/) to facilitate the conversion. ATM, a
## 2.0.1

*Released July, 16, 2024*
[Beacon-v2.0.1](https://github.com/ga4gh-beacon/beacon-v2/tree/f6f85c445922831bd398552384593206c86287de)

* Replaced ENSGLOSSARY for SO ontology family in documentation examples
* Moved CURIE to beaconCommonComponents
Expand All @@ -51,6 +61,7 @@ There is a set of tools in [`/bin`](./bin/) to facilitate the conversion. ATM, a
## 2.0.0

*Released June, 21, 2022*
[Beacon-v2.0.0](https://github.com/ga4gh-beacon/beacon-v2/tree/d07ef1626321f7428374a4f68d864dfa5e98370f)

* change notes with respect to the repository & documentation are now in [docs.genomebeacons.org](https://docs.genomebeacons.org/changes-todo/)
* NOTE: on 2022-06-20 the previous development repositories have been archived:
Expand Down
2 changes: 1 addition & 1 deletion bin/beaconYamler.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/local/bin/python3
#!/usr/bin/env python3

import sys, re, json
import pathlib
Expand Down
4 changes: 2 additions & 2 deletions bin/beacon_yaml2md.pl
Original file line number Diff line number Diff line change
Expand Up @@ -729,9 +729,9 @@ sub add_properties_vrs {
my ( $property, $data ) = @_;
my %url = (
'SequenceExpression' =>
'https://raw.githubusercontent.com/ga4gh/vrs/1.2/schema/vrs.json#/$defs/',
'https://w3id.org/ga4gh/schema/vrs/1.3/vrs.json#/definitions/',
'CopyNumber' =>
'https://raw.githubusercontent.com/ga4gh/vrs/1.2/schema/vrs.json#/$defs/'
'https://w3id.org/ga4gh/schema/vrs/1.3/vrs.json#/definitions/'
);
if ( exists $url{$property} ) {
$data->{properties} =
Expand Down
4 changes: 2 additions & 2 deletions bin/deref_schemas/biosamples/defaultSchema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ properties:
title: Value
type: object
- $schema: https://json-schema.org/draft/2020-12/schema
definitions:
$defs:
TypedQuantity:
properties:
quantity:
Expand Down Expand Up @@ -1064,7 +1064,7 @@ properties:
description: List of phenotypic abnormalities of the sample. RECOMMENDED.
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or biosample.
properties:
evidence:
Expand Down
8 changes: 4 additions & 4 deletions bin/deref_schemas/cohorts/defaultSchema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
$comment: 'version: ga4gh-beacon-cohort-v2.0.0'
$schema: https://json-schema.org/draft/2020-12/schema
additionalProperties: &1 !!perl/scalar:JSON::PP::Boolean 1
definitions:
$defs:
CohortCriteria:
description: Criteria used for defining the cohort. It is assumed that all cohort participants will match or NOT match such criteria.
properties:
Expand Down Expand Up @@ -366,7 +366,7 @@ definitions:
description: Phenotypic condition(s) in cohort inclusion criteria
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or biosample.
properties:
evidence:
Expand Down Expand Up @@ -1660,7 +1660,7 @@ properties:
description: Phenotypic condition(s) in cohort inclusion criteria
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or biosample.
properties:
evidence:
Expand Down Expand Up @@ -2406,7 +2406,7 @@ properties:
description: Phenotypic condition(s) in cohort inclusion criteria
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or biosample.
properties:
evidence:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/datasets/defaultSchema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ properties:
dataUseConditions:
$schema: https://json-schema.org/draft/2020-12/schema
additionalProperties: 1
definitions:
$defs:
DUODataUse:
allOf:
- description: 'Data Use Ontology codes and additional information associated with a data object (e.g. sample, dataset).'
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/genomicVariations/defaultSchema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
$comment: 'version: ga4gh-beacon-variant-v2.0.0'
$schema: https://json-schema.org/draft/2020-12/schema
additionalProperties: &1 !!perl/scalar:JSON::PP::Boolean 1
definitions:
$defs:
CaseLevelVariant:
description: ''
properties:
Expand Down
6 changes: 3 additions & 3 deletions bin/deref_schemas/individuals/defaultSchema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ properties:
title: Value
type: object
- $schema: https://json-schema.org/draft/2020-12/schema
definitions:
$defs:
TypedQuantity:
properties:
quantity:
Expand Down Expand Up @@ -1299,7 +1299,7 @@ properties:
items:
$schema: https://json-schema.org/draft/2020-12/schema
additionalProperties: 1
definitions:
$defs:
pedigreeMember:
examples:
- membersInProband:
Expand Down Expand Up @@ -1696,7 +1696,7 @@ properties:
phenotypicFeatures:
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or biosample.
properties:
evidence:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/Complex Value.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
Complex Value:
$schema: https://json-schema.org/draft/2020-12/schema
definitions:
$defs:
TypedQuantity:
properties:
quantity:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/CopyNumber.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
---
CopyNumber:
properties: '[VRS definition for CopyNumber](https://raw.githubusercontent.com/ga4gh/vrs/1.2/schema/vrs.json#/definitions/CopyNumber)'
properties: '[VRS definition for CopyNumber](https://w3id.org/ga4gh/schema/vrs/1.3/vrs.json#/definitions/CopyNumber)'
type: allOf
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/dataUseConditions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
dataUseConditions:
$schema: https://json-schema.org/draft/2020-12/schema
additionalProperties: 1
definitions:
$defs:
DUODataUse:
allOf:
- description: Data Use Ontology codes and additional information associated
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/exclusionCriteria.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ exclusionCriteria:
description: Phenotypic condition(s) in cohort inclusion criteria
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or
biosample.
properties:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/inclusionCriteria.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ inclusionCriteria:
description: Phenotypic condition(s) in cohort inclusion criteria
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or
biosample.
properties:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/measurementValue.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ measurementValue:
properties:
Complex Value:
$schema: https://json-schema.org/draft/2020-12/schema
definitions:
$defs:
TypedQuantity:
properties:
quantity:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/measurements.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ measurements:
title: Value
type: object
- $schema: https://json-schema.org/draft/2020-12/schema
definitions:
$defs:
TypedQuantity:
properties:
quantity:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/measures.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ measures:
title: Value
type: object
- $schema: https://json-schema.org/draft/2020-12/schema
definitions:
$defs:
TypedQuantity:
properties:
quantity:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/pedigrees.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ pedigrees:
items:
$schema: https://json-schema.org/draft/2020-12/schema
additionalProperties: 1
definitions:
$defs:
pedigreeMember:
examples:
- membersInProband:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/phenotypicConditions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ phenotypicConditions:
description: Phenotypic condition(s) in cohort inclusion criteria
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or biosample.
properties:
evidence:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/phenotypicFeatures.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
phenotypicFeatures:
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or biosample.
properties:
evidence:
Expand Down
15 changes: 0 additions & 15 deletions bin/yamlerRunner.sh
Original file line number Diff line number Diff line change
@@ -1,28 +1,13 @@
BASEDIR=$(dirname $0)
UNITYPATH=$BASEDIR/..

# initial conversion from separate schemas
# DEPRECATED
# BEACONMODELPATH=$BASEDIR/../../beacon-v2-Models/BEACON-V2-Model
# BEACONFRAMEWORKPATH=$BASEDIR/../../beacon-framework-v2

BEACONMODELNAME=beacon-v2-default-model

# for UPSTREAM in $BEACONMODELPATH $BEACONFRAMEWORKPATH
# do
# echo "pulling $UPSTREAM"
# git -C $UPSTREAM pull
# done

for KIND in src json
do
mkdir -p $UNITYPATH/models/$KIND/$BEACONMODELNAME
mkdir -p $UNITYPATH/framework/$KIND
done

# $BASEDIR/beaconYamler.py -i $BEACONMODELPATH -t json -x yaml -o $UNITYPATH/models/src/$BEACONMODELNAME
# $BASEDIR/beaconYamler.py -i $BEACONFRAMEWORKPATH -t json -x yaml -o $UNITYPATH/framework/src

# recurring conversion from the source files to the exported versions
$BASEDIR/beaconYamler.py -i $UNITYPATH/models/src/$BEACONMODELNAME -t yaml -x json -o $UNITYPATH/models/json/$BEACONMODELNAME
$BASEDIR/beaconYamler.py -i $UNITYPATH/framework/src -t yaml -x json -o $UNITYPATH/framework/json
2 changes: 1 addition & 1 deletion docs/schemas-md/obj/CopyNumber.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
|Term | Description | Type | Properties | Example | Enum|
| ---| ---| ---| ---| ---| --- |
| CopyNumber | NA | allOf | [VRS definition for CopyNumber](https://raw.githubusercontent.com/ga4gh/vrs/1.2/schema/vrs.json#/definitions/CopyNumber) | NA | NA|
| CopyNumber | NA | allOf | [VRS definition for CopyNumber](https://w3id.org/ga4gh/schema/vrs/1.3/vrs.json#/definitions/CopyNumber) | NA | NA|
6 changes: 1 addition & 5 deletions framework/json/common/beaconCommonComponents.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$defs": {
"$schema": {
"$comment": "TO REVIEW: adding a `format` or `regex` attribute that validates correctly against a file path (relative).",
Expand Down Expand Up @@ -143,10 +142,6 @@
],
"type": "string"
},
"Info": {
"description": "Placeholder to allow the Beacon to return any additional information that is necessary or could be of interest in relation to the query or the entry returned. It is recommended to encapsulate additional informations in this attribute instead of directly adding attributes at the same level than the others in order to avoid collision in the names of attributes in future versions of the specification.",
"type": "object"
},
"Limit": {
"default": 10,
"description": "Size of the page. Use `0` to return all the results or the maximum allowed by the Beacon, if there is any.",
Expand Down Expand Up @@ -243,6 +238,7 @@
"type": "boolean"
}
},
"$schema": "https://json-schema.org/draft/2020-12/schema",
"description": "Definition of relatively simple components used in different points of the Beacon specification, both in requests and responses, therefore not associated exclusively with one or the other. Separate schema documents are provided for complex components.",
"title": "Beacon Common Components",
"type": "object"
Expand Down
6 changes: 6 additions & 0 deletions framework/json/common/info.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
"description": "Placeholder to allow the Beacon to return any additional information that is necessary or could be of interest in relation to the query or the entry returned. It is recommended to encapsulate additional informations in this attribute instead of directly adding attributes at the same level than the others in order to avoid collision in the names of attributes in future versions of the specification.",
"title": "Info",
"type": "object"
}
14 changes: 7 additions & 7 deletions framework/json/configuration/beaconConfigurationSchema.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
"additionalProperties": true,
"$defs": {
"EntryTypes": {
"additionalProperties": {
Expand All @@ -12,7 +10,9 @@
"type": "object"
}
},
"description": "Files complaint with this schema are the configuration ones. The details returned in `service-info` are mirroring the ones in this configuration file.",
"$schema": "https://json-schema.org/draft/2020-12/schema",
"additionalProperties": true,
"description": "The Beacon configuration reports several attributes of the beacon instance related to security, maturity and available entry types. Where appropriate the details returned in `service-info` should mirror the ones in this configuration.",
"properties": {
"$schema": {
"$ref": "../common/beaconCommonComponents.json#/$defs/$schema"
Expand All @@ -24,7 +24,7 @@
"description": "Declares the level of maturity of the Beacon instance.",
"properties": {
"productionStatus": {
"description": "`DEV`= 'Service potentially unstable, not real data', which availability and data should not be used in production setups. `TEST`= 'Service stable, not real data'. 'PROD'= 'Service stable, actual data'.",
"description": "* `DEV`: Service potentially unstable, _i.e._ potentially not real data,\n inconsistent availability; data should not be used in production setups \n* `TEST`: Service is stable but data should be considered synthetic * `PROD`: Service stable with real world data ",
"enum": [
"DEV",
"TEST",
Expand All @@ -43,11 +43,11 @@
"description": "Default granularity. Some responses could return higher detail, but this would be the granularity by default."
},
"securityLevels": {
"default": [
"CONTROLLED"
],
"description": "All access levels supported by the Beacon. Any combination is valid, as every option would apply to different parts of the Beacon.",
"items": {
"default": [
"CONTROLLED"
],
"enum": [
"PUBLIC",
"REGISTERED",
Expand Down
4 changes: 2 additions & 2 deletions framework/json/configuration/beaconMapSchema.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
"additionalProperties": true,
"$defs": {
"Endpoint": {
"properties": {
Expand Down Expand Up @@ -56,6 +54,8 @@
"type": "object"
}
},
"$schema": "https://json-schema.org/draft/2020-12/schema",
"additionalProperties": true,
"description": "Map of a Beacon, its entry types and endpoints. It isconceptually similar to a website sitemap.",
"properties": {
"$schema": {
Expand Down
10 changes: 5 additions & 5 deletions framework/json/configuration/entryTypeDefinition.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
"$ref": "../common/beaconCommonComponents.json#/$defs/$schema"
},
"aCollectionOf": {
"description": "If the entry type is a collection of other entities, (e.g. a Dataset is a collection of Records), then this attribute must list the entities that can be included. One _collection_ can include more than one entry type (e.g. a Dataset in teh Beacon cdefault model could include Individuals, Biosamples, GenomicVariations, Analyses amnd Runs). In such cases in each individual response (e.g. `resultSetsResponse` of collections of type \"dataset\") will contain entries of a single entry type (e.g. biosamples) even if a dataset may contain records of multiple types.",
"includedConcepts": {
"$ref": "../common/basicElement.json",
"type": "array"
"description": "If the entry type is a collection of other entry types, (e.g. a Dataset is a collection of Records), then this attribute must list the entry types that could be included. One collection type could be defined as included more than one entry type (e.g. a Dataset could include Individuals or Genomic Variants), in such cases the entries are alternative, meaning that a given instance of this entry type could be of only one of the types (e.g. a given Dataset contains Individuals, while another Dataset could contain Genomic Variants, but not both at once).",
"type": "array",
"items": {
"$ref": "../common/basicElement.json"
}
},
"additionallySupportedSchemas": {
Expand Down Expand Up @@ -71,4 +71,4 @@
],
"title": "",
"type": "object"
}
}
Loading

0 comments on commit 724b65c

Please sign in to comment.