Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework refactor entry type definitions #102

Closed
wants to merge 39 commits into from

Conversation

mbaudis
Copy link
Member

@mbaudis mbaudis commented Jul 11, 2023

Some streamlining of the entryTypesDefinition schema. I think this is just a streamlining of the code which was a bit confusing but please check ...

mbaudis and others added 30 commits March 14, 2023 16:31
Some test changes for the new build workflow from website-docs
test edit
correction of a typo
Documentation: Additional contribution/development pages together with a reorganization of the navigation structure.

Also, clarification of the cohorts relation (#80).
More details and examples about the use of filters in various scenarios, including GET examples for age etc.

A main change here is the alignment of the filter types w/ the specification (e.g. no separate "numeric" type).
... and fixing `filterTerms` => `filteringTerms`
This is an attempt to get the documentation site towards "clean HTTPS"
* separate pages for records and handovers
* navigation restructuring

... more content to follow
Edits have to be done in YAML and then propagated to JSON using bin/yamlerRunner.sh
Oriol López-Doriga and others added 6 commits June 16, 2023 13:29
removed the example on "numerical" filters, amended a couple of examples
This change should AFAIK not change any logic but is just performed to disentangle and simplify the `entryTypesSchema`.

Additional edits only reformat descriptions etc.
@mbaudis mbaudis requested review from costero-e and redmitry July 11, 2023 15:14
@mbaudis
Copy link
Member Author

mbaudis commented Jul 11, 2023

... also this seems to update the develop branch w/ a massive code alignment.

@costero-e => Please decide about the branch management there and think about cleaning/retiring branches which aren't used anymore ¯_(ツ)_/¯

costero-e
costero-e previously approved these changes Jul 17, 2023
Copy link
Collaborator

@costero-e costero-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine and is great to switch from http to https, as I see it is one of the main corrections along the files.

@costero-e
Copy link
Collaborator

For the branches management, this is the short-term plan:
Deleted branches
genomicVariations_add-pathogenicity-predictions
clean-up_remove-validator-remnants
clean-up_remove_aggregated_response

Branches that will be deleted after PR #92
entry-type-definitions-cleanup

Branches that will be deleted after PR #90
hotfix_filteringTermsResults

Branches that will be deleted after PR #82
schema-urgent-fixes

Branches that will be deleted after PR #74
clean-up_renaming_entity_to_entry_type

Branches that will be deleted after this PR (#102)
framework-refactor-entry-type-definitions

For the mid-term plan, I will write what we are doing in every branch and add milestones and achievements.

@jrambla
Copy link
Contributor

jrambla commented Jan 9, 2024

Is this PR still mergeable?

@costero-e
Copy link
Collaborator

Hi @jrambla . Yes, it is mostly documentation and style updates apart from http to https changes. I think this won't break specifications. We need 1 pending review.

@jrambla jrambla added this to the 2.2.0 milestone Oct 8, 2024
@jrambla jrambla self-requested a review October 8, 2024 04:57
@costero-e costero-e dismissed their stale review October 8, 2024 08:35

Changes already merged in other PR

@costero-e
Copy link
Collaborator

Closing this PR as some of this was already merged in other PR and conflicting files did not make it mergeable anymore.

@costero-e costero-e closed this Oct 8, 2024
@costero-e costero-e deleted the framework-refactor-entry-type-definitions branch December 13, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants