-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework refactor entry type definitions #102
Conversation
Some test changes for the new build workflow from website-docs
test edit
correction of a typo
Update README.md
Documentation: Additional contribution/development pages together with a reorganization of the navigation structure. Also, clarification of the cohorts relation (#80).
More details and examples about the use of filters in various scenarios, including GET examples for age etc. A main change here is the alignment of the filter types w/ the specification (e.g. no separate "numeric" type).
... and fixing `filterTerms` => `filteringTerms`
This is an attempt to get the documentation site towards "clean HTTPS"
* separate pages for records and handovers * navigation restructuring ... more content to follow
see "changes" on the site
Edits have to be done in YAML and then propagated to JSON using bin/yamlerRunner.sh
complexValue required type fixed
removed the example on "numerical" filters, amended a couple of examples
This change should AFAIK not change any logic but is just performed to disentangle and simplify the `entryTypesSchema`. Additional edits only reformat descriptions etc.
... also this seems to update the develop branch w/ a massive code alignment. @costero-e => Please decide about the branch management there and think about cleaning/retiring branches which aren't used anymore ¯_(ツ)_/¯ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine and is great to switch from http to https, as I see it is one of the main corrections along the files.
For the branches management, this is the short-term plan: Branches that will be deleted after PR #92 Branches that will be deleted after PR #90 Branches that will be deleted after PR #82 Branches that will be deleted after PR #74 Branches that will be deleted after this PR (#102) For the mid-term plan, I will write what we are doing in every branch and add milestones and achievements. |
Is this PR still mergeable? |
Hi @jrambla . Yes, it is mostly documentation and style updates apart from http to https changes. I think this won't break specifications. We need 1 pending review. |
Closing this PR as some of this was already merged in other PR and conflicting files did not make it mergeable anymore. |
Some streamlining of the entryTypesDefinition schema. I think this is just a streamlining of the code which was a bit confusing but please check ...